[Sofa.Core][SofaBaseTopology] Move TopologyData* from SofaBaseTopology to Sofa.Core #2423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredroy
added
pr: status to review
fredroy
force-pushed
the
move_topologydata
branch
from
9fc03a1
to
50d4a73
Compare
|
[ci-build][with-all-tests] |
|
fixed conflict, if CI is 🟢 then I am too |
|
[ci-build][with-all-tests] |
👺🤬 |
epernod
reviewed
Oct 25, 2021
...Mechanics/src/SofaBaseMechanics/BarycentricMappers/BarycentricMapperTetrahedronSetTopology.h
Show resolved
Hide resolved
SofaKernel/modules/Sofa.Compat/src/SofaBaseTopology/TopologyDataHandler.h
Outdated
Show resolved
Hide resolved
epernod
approved these changes
Oct 26, 2021
epernod
added
pr: status ready
fredroy
added a commit
to fredroy/sofa
that referenced
this pull request
Oct 26, 2021
…y to Sofa.Core (sofa-framework#2423) * move files * reflect move in cmake files * reflect move in headers * change namespace * add compat layer for the move * remove unnecessary fwd declation in core Co-authored-by: Hugo <hugo.talbot@sofa-framework.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing task #2402
"Simple" PR moving all code related to TopologyData/Handler from SofaBaseTopology to Sofa.Core, along the other core topology structure.
A lot of modules wont need SofaBaseTopology anymore because it was including TopologyData.inl from it....
As usual, there is a compatibility layer which surprisingly works very well in this case (i did not touch any other file in other plugins/modules)
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if