Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaTopologyMapping] Fix shadowed variable #2158 #2413

Merged
merged 2 commits into from
Oct 14, 2021
Merged

[SofaTopologyMapping] Fix shadowed variable #2158 #2413

merged 2 commits into from
Oct 14, 2021

Conversation

alxbilger
Copy link
Contributor

Fix issue #2158

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Oct 14, 2021
@alxbilger @epernod
Apply suggestions from code review
d206397 
Co-authored-by: erik pernod <erik.pernod@gmail.com>
@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Oct 14, 2021
@fredroy fredroy merged commit 144e66d into sofa-framework:master Oct 14, 2021
@guparan guparan added this to the v21.12 milestone Nov 18, 2021
@alxbilger alxbilger deleted the topo_shadow_variable branch June 28, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epernod epernod epernod approved these changes

Assignees
No one assigned
Labels
pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v21.12
Development

Successfully merging this pull request may close these issues.
4 participants
@alxbilger @epernod @guparan @fredroy