Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaBaseMechanics] Remove TopologyHandler in masses to use TopologyData callbacks (part 5) #2391

Merged
merged 7 commits into from
Oct 22, 2021
Merged

[SofaBaseMechanics] Remove TopologyHandler in masses to use TopologyData callbacks (part 5) #2391

merged 7 commits into from
Oct 22, 2021

Conversation

epernod
Copy link
Contributor

@epernod epernod commented Oct 8, 2021 •
edited
Loading

Remove TopologyHandler instances in FEM and set topology callbacks directly using TopologyData thanks to PR #2375
Updated components:

  • DiagonalMass
  • MeshMatrixMass

Also fix DiagonalMass topological changes for Quad topology and update test which was wrong.

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@epernod epernod added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Oct 8, 2021
@epernod epernod self-assigned this Oct 8, 2021
@epernod epernod mentioned this pull request Oct 11, 2021
Merged
@epernod
Copy link
Contributor Author

epernod commented Oct 12, 2021

[ci-build][with-all-tests]

@epernod epernod added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Oct 12, 2021
@fredroy
Copy link
Contributor

fredroy commented Oct 18, 2021

Sorry but a lot of tests are failing 😥 (either units, scenes and regression)

@epernod
[SofaBaseMechanics] Update DiagonalMass and MeshMatrixMass checks on …
04f6efe 
…totalMass, massDensity and vertexMass to send warnings only if values are strictly negatives
@epernod epernod added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Oct 20, 2021
@epernod
Copy link
Contributor Author

epernod commented Oct 20, 2021

[ci-build][with-all-tests]

@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Oct 22, 2021
@fredroy fredroy merged commit e453628 into sofa-framework:master Oct 22, 2021
@epernod epernod deleted the inf_mass_DataHandler_up branch October 23, 2021 12:05
@guparan guparan added this to the v21.12 milestone Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredroy fredroy fredroy approved these changes

Assignees

@epernod epernod

Labels
pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v21.12
Development

Successfully merging this pull request may close these issues.
3 participants
@epernod @fredroy @guparan