-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SofaBaseMechanics] Remove TopologyHandler in masses to use TopologyData callbacks (part 5) #2391
Merged
fredroy
merged 7 commits into
sofa-framework:master
from
epernod:inf_mass_DataHandler_up
Oct 22, 2021
Merged
[SofaBaseMechanics] Remove TopologyHandler in masses to use TopologyData callbacks (part 5) #2391
fredroy
merged 7 commits into
sofa-framework:master
from
epernod:inf_mass_DataHandler_up
Oct 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llbacks directly in the TopologyData.
…llbacks directly in the TopologyData.
epernod
added
pr: status to review
To notify reviewers to review this pull-request
pr: clean
Cleaning the code
labels
Oct 8, 2021
[ci-build][with-all-tests] |
epernod
added
pr: status wip
Development in the pull-request is still in progress
and removed
pr: status to review
To notify reviewers to review this pull-request
labels
Oct 12, 2021
Sorry but a lot of tests are failing 😥 (either units, scenes and regression) |
…totalMass, massDensity and vertexMass to send warnings only if values are strictly negatives
epernod
added
pr: status to review
To notify reviewers to review this pull-request
and removed
pr: status wip
Development in the pull-request is still in progress
labels
Oct 20, 2021
[ci-build][with-all-tests] |
fredroy
approved these changes
Oct 22, 2021
fredroy
added
pr: status ready
Approved a pull-request, ready to be squashed
and removed
pr: status to review
To notify reviewers to review this pull-request
labels
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove TopologyHandler instances in FEM and set topology callbacks directly using TopologyData thanks to PR #2375
Updated components:
Also fix DiagonalMass topological changes for Quad topology and update test which was wrong.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if