[SofaBaseTopology] Ensure to add a topology EndingEvent before propagating to all topologyData #2376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng the queue of events to the handlers
epernod
added
pr: fast merge
hugtalbot
reviewed
Oct 6, 2021
| @@ -434,6 +434,8 @@ void PointSetTopologyModifier::propagateTopologicalChanges() | |||
| { | |||
| if (m_container->beginChange() == m_container->endChange()) return; // nothing to do if no event is stored | |||
|
|
|||
| sofa::core::topology::EndingEvent* e = new sofa::core::topology::EndingEvent(); | |||
fredroy
added
pr: status ready
guparan
pushed a commit
that referenced
this pull request
Oct 28, 2021
…2377) This PR depends on #2374 #2375 and #2376 and should be rebased before review. - Remove old method `handleTopologyChange` - Turn d_indices into TopologySubsetIndices, this automatically fix the topological changes update. - Fix the use of subset indices combined with topology changes. - Add callback on endingEvent to update the totalMass/vertexMass - Fix the center of gravity display when using subset of indices ______________________________________________________ Co-authored-by: Hugo <hugo.talbot@sofa-framework.org> Co-authored-by: Frederick Roy <fredroy@users.noreply.github.com>
fredroy
added a commit
to fredroy/sofa
that referenced
this pull request
Nov 8, 2021
…ofa-framework#2377) This PR depends on sofa-framework#2374 sofa-framework#2375 and sofa-framework#2376 and should be rebased before review. - Remove old method `handleTopologyChange` - Turn d_indices into TopologySubsetIndices, this automatically fix the topological changes update. - Fix the use of subset indices combined with topology changes. - Add callback on endingEvent to update the totalMass/vertexMass - Fix the center of gravity display when using subset of indices ______________________________________________________ Co-authored-by: Hugo <hugo.talbot@sofa-framework.org> Co-authored-by: Frederick Roy <fredroy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add topology EndingEvent to the queue of event each time before propagating. This event can be catch by callback if needed.
See next PR with uniformMass
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if