[Sofa.Core] Use links instead of private std::list

[alxbilger]

A ConstraintCorrection stores the list of constraint solvers using it. This is mainly to notice them to stop using them when they are destroyed (in the cleanup method).
This list was a std::list. I suggest a MultiLink instead.

---

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

---

Reviewers will merge this pull-request only if

• it builds with SUCCESS for all platforms on the CI.
• it does not generate new warnings.
• it does not generate new unit test failures.
• it does not generate new scene test failures.
• it does not break API compatibility.
• it is more than 1 week old (or has fast-merge label).

[fredroy]

[ci-build][with-all-tests]

[hugtalbot]

👍
Let's just wait the usual 7 days, then it can be ready to me

[fredroy]

One (new) scene is failing: SceneTests.applications/plugins/LMConstraint/examples.DOFBlockerLMConstraint.scn
The error message is: [ERROR] [UncoupledConstraintCorrection(default67)] Cannot remove the requested constraint solver
It is possible that the scene itself was wrong but it is highlighted here because you add a msg_error()

[alxbilger]

[ci-build][with-all-tests]

[alxbilger]

The error in the tests came from (applications/plugins/LMConstraint/src/LMConstraint/LMConstraintSolver.cpp) in init:

listConstraintCorrection[i]->removeConstraintSolver(this);
listConstraintCorrection[i]->addConstraintSolver(this);

The first line removed the element from the list whereas the element was never added to the list (we are in the init method). It is added in the second line.