-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sofa.Core] Use links instead of private std::list #2364
[Sofa.Core] Use links instead of private std::list #2364
Conversation
SofaKernel/modules/SofaCore/src/sofa/core/behavior/ConstraintCorrection.inl
Outdated
Show resolved
Hide resolved
[ci-build][with-all-tests] |
👍 |
One (new) scene is failing: |
[ci-build][with-all-tests] |
The error in the tests came from (applications/plugins/LMConstraint/src/LMConstraint/LMConstraintSolver.cpp) in listConstraintCorrection[i]->removeConstraintSolver(this);
listConstraintCorrection[i]->addConstraintSolver(this); The first line removed the element from the list whereas the element was never added to the list (we are in the |
A
ConstraintCorrection
stores the list of constraint solvers using it. This is mainly to notice them to stop using them when they are destroyed (in the cleanup method).This list was a
std::list
. I suggest aMultiLink
instead.By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if