[SofaBaseTopology] Fix Last element index update in TopologyData #2359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Generalize it's use in TopologyData during add or remove event to avoid bad access index during successive remove elements events. (cherry picked from commit 133e76b)
epernod
added
pr: fix
|
[ci-build][with-all-tests] |
|
mac: |
fredroy
reviewed
Sep 27, 2021
SofaKernel/modules/SofaCore/src/sofa/core/topology/BaseTopologyData.h
Outdated
Show resolved
Hide resolved
fredroy
reviewed
Sep 27, 2021
SofaKernel/modules/SofaCore/src/sofa/core/topology/BaseTopologyData.h
Outdated
Show resolved
Hide resolved
what a shame I don't have a mac to test here :) |
Windows is even better: |
epernod
added
pr: status wip
…ght topological buffer this data is linked to. In case of cross topology linked, the size was overriden
epernod
force-pushed
the
inf_fix_topoDataLastIndex
branch
from
9c7e1be
to
3b628d5
Compare
Co-authored-by: Frederick Roy <fredroy@users.noreply.github.com>
epernod
added
pr: status to review
|
[ci-build][with-all-tests] |
hugtalbot
added
pr: status ready
alxbilger
reviewed
Sep 29, 2021
SofaKernel/modules/SofaBaseTopology/src/SofaBaseTopology/TopologyData.inl
Outdated
Show resolved
Hide resolved
hugtalbot
approved these changes
Sep 29, 2021
…ogyData.inl Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com>
damienmarchal
pushed a commit
to CRIStAL-PADR/sofa
that referenced
this pull request
Oct 11, 2021
…a-framework#2359) * [SofaBaseTopology] Update lastElementIndex to add m_ and add accessor. Generalize it's use in TopologyData during add or remove event to avoid bad access index during successive remove elements events. (cherry picked from commit 133e76b) * [SofaBaseTopology] Fix data last element should be only set by the right topological buffer this data is linked to. In case of cross topology linked, the size was overriden * [SofaBaseTopology] Fix non windows compilation * [SofaBaseTopology] Fix conversion warning * Apply suggestions from code review Co-authored-by: Frederick Roy <fredroy@users.noreply.github.com> * Update SofaKernel/modules/SofaBaseTopology/src/SofaBaseTopology/TopologyData.inl Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com> Co-authored-by: Frederick Roy <fredroy@users.noreply.github.com> Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lastElementIndexintom_lastElementIndexapi is converging but this PR might have some side effects...
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if