-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SofaBaseTopology] Fix Last element index update in TopologyData #2359
[SofaBaseTopology] Fix Last element index update in TopologyData #2359
Conversation
…. Generalize it's use in TopologyData during add or remove event to avoid bad access index during successive remove elements events. (cherry picked from commit 133e76b)
[ci-build][with-all-tests] |
mac: |
SofaKernel/modules/SofaCore/src/sofa/core/topology/BaseTopologyData.h
Outdated
Show resolved
Hide resolved
SofaKernel/modules/SofaCore/src/sofa/core/topology/BaseTopologyData.h
Outdated
Show resolved
Hide resolved
what a shame I don't have a mac to test here :) |
Windows is even better: |
…ght topological buffer this data is linked to. In case of cross topology linked, the size was overriden
9c7e1be
to
3b628d5
Compare
Co-authored-by: Frederick Roy <fredroy@users.noreply.github.com>
[ci-build][with-all-tests] |
SofaKernel/modules/SofaBaseTopology/src/SofaBaseTopology/TopologyData.inl
Outdated
Show resolved
Hide resolved
…ogyData.inl Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com>
…a-framework#2359) * [SofaBaseTopology] Update lastElementIndex to add m_ and add accessor. Generalize it's use in TopologyData during add or remove event to avoid bad access index during successive remove elements events. (cherry picked from commit 133e76b) * [SofaBaseTopology] Fix data last element should be only set by the right topological buffer this data is linked to. In case of cross topology linked, the size was overriden * [SofaBaseTopology] Fix non windows compilation * [SofaBaseTopology] Fix conversion warning * Apply suggestions from code review Co-authored-by: Frederick Roy <fredroy@users.noreply.github.com> * Update SofaKernel/modules/SofaBaseTopology/src/SofaBaseTopology/TopologyData.inl Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com> Co-authored-by: Frederick Roy <fredroy@users.noreply.github.com> Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com>
lastElementIndex
intom_lastElementIndex
api is converging but this PR might have some side effects...
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if