[Sofa.Helper] Fix and micro-optimize AdvancedTimer #2349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxbilger
added
pr: clean
|
[ci-build][with-all-tests] |
|
[ci-depends-on] detected during build #6. To unlock the merge button, you must
|
| const char* message; | ||
| ScopedAdvancedTimer(const std::string& message); | ||
| ScopedAdvancedTimer( const char* message ); | ||
| AdvancedTimer::IdStep m_id; |
There was a problem hiding this comment.
I know this is not the topic of the PR and it is more about general c++ coding practice but including thousand of dependencies lines to get something that in fact is an integer is really problematic. I wonder what kind of design pattern should be used instead of these inner typedefs.
fredroy
approved these changes
Sep 21, 2021
fredroy
added
pr: status ready
guparan
added
the
pr: backport todo
guparan
pushed a commit
that referenced
this pull request
Oct 25, 2021
* [Sofa.Helper] Store id as an id rather than the message used to find the id * [Sofa.Helper] Use map for constant complexity instead of a std::vector * [SofaCore] Missing include * [SofaCore] Missing include * [SofaCore] Missing include * [SofaCore] Missing include
guparan
removed
the
pr: backport todo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScopedAdvancedTimer, store the timer id as a real id rather than thestd::stringused to find the real id. This fixes a strange bug occurring withScopedAdvancedTimer(which I am not able to explain).AdvancedTimer, use a map for constant complexity when searching an id, instead of astd::vector[ci-depends-on https://github.com/sofa-framework/Compliant/pull/2]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if