Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[all] Clean unreferenced files #2333

Merged
merged 3 commits into from
Sep 22, 2021
Merged

Conversation

alxbilger
Copy link
Contributor

@alxbilger alxbilger commented Sep 9, 2021

  • SofaGeneralDeformable/MeshSpringForceField.inl -> deleted because not referenced in CMakeLists (probably an artefact when this file has been moved, but I did not check)

  • modules/SofaGeneralEngine/src/SofaGeneralEngine/SelectConnectedLabelsROI.h: Header file wrongly referenced in CMakeLists: .cpp instead of .h

  • LaparoscopicRigidMapping: Was not compiled at all. Is it still useful? It seems it cannot compile, so I removed the files

  • @fredroy: What should we do with NonUniformHexahedronFEMForceFieldDensity? Its reference is commented in the CMakeLists. I did not touch it.

  • SofaKernel/modules/SofaCore/src/sofa/core/behavior/InertiaForce.h -> removed because not used and not referenced in CMakeLists

  • SofaKernel/modules/SofaCore/src/sofa/core/collision/ParallelPipeline.h and .cpp -> removed because empty class, not used and not referenced in CMakeLists

  • DevBaseMonitor: appears to be used but not referenced in CMakeLists -> added

  • SofaKernel/modules/SofaHelper/src/sofa/helper/io/MassSpringLoader.h -> removed

  • SofaKernel/modules/SofaHelper/src/sofa/helper/io/bvh -> removed

  • SofaKernel/modules/SofaHelper/src/sofa/helper/logging/LoggerMessageHandler.h and .cpp -> removed because not used and not referenced in CMakeLists

  • SofaKernel/modules/SofaHelper/src/sofa/helper/FnDispatcher.cpp -> removed because empty, and not referenced in CMakeLists

  • SofaKernel/modules/SofaSimulationCore/src/sofa/simulation/ChangeListener.h and .cpp -> removed because not used, and not referenced in CMakeLists

  • SofaKernel/modules/SofaSimulationCore/src/sofa/simulation/MechanicalMatrixVisitor.h -> removed because empty, and not referenced in CMakeLists

  • SofaKernel/modules/Sofa.Type/src/sofa/type/Color.cpp -> removed because not referenced in CMakeLists. The code in this file is not required.


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: clean Cleaning the code pr: status to review To notify reviewers to review this pull-request labels Sep 9, 2021
@fredroy
Copy link
Contributor

fredroy commented Sep 10, 2021

* @fredroy: What should we do with NonUniformHexahedronFEMForceFieldDensity? Its reference is commented in the CMakeLists. I did not touch it.

IMO:

  • nobody complained about its absence in the project since... ?
  • no relevant commits since a loooooooong time
  • no example
  • almost no doc (although a paper citation is present)
  • obviously no test
  • it needs a kind of file (density volume), but we dont even know the format/standard, and if there is one in the repo already...

I would simply delete it 🧐

@fredroy
Copy link
Contributor

fredroy commented Sep 10, 2021

[ci-build][with-all-tests]

@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Sep 22, 2021
@hugtalbot hugtalbot merged commit 70bb123 into sofa-framework:master Sep 22, 2021
@guparan guparan added this to the v21.12 milestone Oct 1, 2021
@alxbilger alxbilger deleted the clean_unused branch June 28, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants