Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CMake] FIX libs copy on Windows #2261

Merged
merged 1 commit into from
Jul 28, 2021
Merged

[CMake] FIX libs copy on Windows #2261

merged 1 commit into from
Jul 28, 2021

Conversation

guparan
Copy link
Contributor

@guparan guparan commented Jul 21, 2021

Fix libs copy on Windows with multi-config generator (Visual Studio).

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@guparan guparan added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Jul 21, 2021
epernod
epernod approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@epernod epernod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jul 28, 2021
@alxbilger alxbilger merged commit 31e5621 into sofa-framework:master Jul 28, 2021
@guparan guparan added this to the v21.12 milestone Oct 1, 2021
@guparan guparan deleted the fix_libs_copy_windows branch October 29, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epernod epernod epernod approved these changes

Assignees
No one assigned
Labels
pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v21.12
Development

Successfully merging this pull request may close these issues.
4 participants
@guparan @epernod @alxbilger @fredroy