Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaMiscForceField] Fix massDensity vector update when adding new elements in MeshMatrixMass #2257

Merged
merged 1 commit into from
Jul 28, 2021
Merged

[SofaMiscForceField] Fix massDensity vector update when adding new elements in MeshMatrixMass #2257

merged 1 commit into from
Jul 28, 2021

Conversation

epernod
Copy link
Contributor

@epernod epernod commented Jul 20, 2021

Add method to compute the good element density using ancestors and coefs values.
Update all toplogy addElement to take into account ancestors indices and coefficients.

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@epernod
[MeshMatrixMass] Fix massDensity vector update when adding new elemen…
aad0302 
…ts. Add method to compute the good element density using ancestors and coefs values
@epernod epernod added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Jul 20, 2021
@epernod epernod self-assigned this Jul 20, 2021
@epernod
Copy link
Contributor Author

epernod commented Jul 20, 2021

[ci-build][with-all-tests]

@guparan guparan added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Jul 21, 2021
@epernod epernod added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Jul 28, 2021
@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jul 28, 2021
@fredroy fredroy merged commit c9d7bb0 into sofa-framework:master Jul 28, 2021
@guparan guparan added this to the v21.12 milestone Oct 1, 2021
@epernod epernod deleted the inf_topo_MMMass branch October 31, 2021 19:24
@guparan guparan changed the title [MeshMatrixMass] Fix massDensity vector update when adding new elements [SofaMiscForceField] Fix massDensity vector update when adding new elements in MeshMatrixMass Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@epernod epernod

Labels
pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v21.12
Development

Successfully merging this pull request may close these issues.
3 participants
@epernod @guparan @fredroy