[CGALPlugin] FIX sofa::type #2246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedroperrusi
added
pr: fix
pedroperrusi
added
the
pr: status to review
fredroy
added
pr: status ready
fredroy
approved these changes
Jul 12, 2021
fredroy
reviewed
Jul 12, 2021
| @@ -508,21 +508,21 @@ void CylinderMesh<DataTypes>::draw(const sofa::core::visual::VisualParams* vpara | |||
| points.resize(m_nbVertices); | |||
| for (int i = 0; i < m_nbVertices; ++i) | |||
| points[i] = coords[i]; | |||
| vparams->drawTool()->drawPoints(points,8,helper::types::RGBAColor(0.0, 0.0, 1.0,1)); | |||
| vparams->drawTool()->drawPoints(points,8,type::RGBAColor(0.0, 0.0, 1.0,1)); | |||
There was a problem hiding this comment.
(just a comment) next time, if the color is obvious, replace it with the named function, like
type::RGBAColor::green() in this case
There was a problem hiding this comment.
Thanks,
I see and often use the new handy functions for colors
Since this was only a fix, I did not bother to change the source beyond compilation
epernod
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix sofa::type namespace variables in CGALPlugin for release v21.06.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if