Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SofaBoundaryCondition] Fix ProjectToLineConstraint_RemovingMeshTest.scn #2241

Merged
merged 1 commit into from
Jul 10, 2021

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Jul 9, 2021

Detected by the CI sporadically.
The crash is triggered "correctly" when executing in Debug mode.

The problem comes from the fact that the stored Jacobian matrix is not updated when the model (i.e mechanicalObject) is modified topologically.
There are some problems still with topological changes (#2242 ) so I opted for a check every time projectResponse() is called.
Not ideal so would need to be changed once topological changes mechanism is finished.

Also create a updateJacobian() method (instead of reinit())


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request pr: backport todo This PR will be backported into the release preceeding its milestone. labels Jul 9, 2021
@fredroy
Copy link
Contributor Author

fredroy commented Jul 9, 2021

[ci-build][with-all-tests]

@epernod epernod added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jul 10, 2021
@epernod epernod merged commit 8d36313 into sofa-framework:master Jul 10, 2021
@guparan guparan added this to the v21.12 milestone Jul 28, 2021
guparan pushed a commit that referenced this pull request Sep 23, 2021
@guparan guparan added pr: backport done This PR has been backported into the release before its milestone. and removed pr: backport todo This PR will be backported into the release preceeding its milestone. labels Oct 4, 2021
@fredroy fredroy deleted the fix_projectlineconstraint branch October 14, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: backport done This PR has been backported into the release before its milestone. pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants