-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[All] Fix minor compilation warnings #2233
Merged
fredroy
merged 9 commits into
sofa-framework:master
from
CRIStAL-PADR:pr-fix-minor-compilation-warning
Jul 13, 2021
Merged
[All] Fix minor compilation warnings #2233
fredroy
merged 9 commits into
sofa-framework:master
from
CRIStAL-PADR:pr-fix-minor-compilation-warning
Jul 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damienmarchal
added
pr: status to review
To notify reviewers to review this pull-request
pr: clean
Cleaning the code
labels
Jul 8, 2021
guparan
added
pr: fast merge
Minor change that can be merged without waiting for the 7 review days
pr: status ready
Approved a pull-request, ready to be squashed
and removed
pr: status to review
To notify reviewers to review this pull-request
labels
Jul 9, 2021
guparan
approved these changes
Jul 9, 2021
epernod
requested changes
Jul 10, 2021
modules/SofaMiscForceField/SofaMiscForceField_test/MeshMatrixMass_test.cpp
Show resolved
Hide resolved
epernod
added
pr: status wip
Development in the pull-request is still in progress
and removed
pr: status ready
Approved a pull-request, ready to be squashed
labels
Jul 10, 2021
As requested.
fredroy
added
pr: status to review
To notify reviewers to review this pull-request
and removed
pr: status wip
Development in the pull-request is still in progress
labels
Jul 12, 2021
[ci-build][with-all-tests] |
epernod
reviewed
Jul 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry previous comment was not clear. Here is my suggestion
modules/SofaMiscForceField/SofaMiscForceField_test/MeshMatrixMass_test.cpp
Outdated
Show resolved
Hide resolved
modules/SofaMiscForceField/SofaMiscForceField_test/MeshMatrixMass_test.cpp
Outdated
Show resolved
Hide resolved
…ass_test.cpp Co-authored-by: erik pernod <erik.pernod@gmail.com>
…ass_test.cpp Co-authored-by: erik pernod <erik.pernod@gmail.com>
epernod
approved these changes
Jul 12, 2021
epernod
added
pr: status ready
Approved a pull-request, ready to be squashed
and removed
pr: status to review
To notify reviewers to review this pull-request
labels
Jul 13, 2021
guparan
changed the title
[FIX] minor compilation warnings
[All] Fix minor compilation warnings
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr: clean
Cleaning the code
pr: fast merge
Minor change that can be merged without waiting for the 7 review days
pr: status ready
Approved a pull-request, ready to be squashed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if