Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[All] Fix minor compilation warnings #2233

Merged
merged 9 commits into from
Jul 13, 2021
Merged

[All] Fix minor compilation warnings #2233

merged 9 commits into from
Jul 13, 2021

Conversation

damienmarchal
Copy link
Contributor

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@damienmarchal damienmarchal added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Jul 8, 2021
@guparan guparan added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jul 9, 2021
@epernod epernod added pr: status wip Development in the pull-request is still in progress and removed pr: status ready Approved a pull-request, ready to be squashed labels Jul 10, 2021
@fredroy fredroy added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Jul 12, 2021
@fredroy
Copy link
Contributor

fredroy commented Jul 12, 2021

[ci-build][with-all-tests]

epernod
epernod reviewed Jul 12, 2021
View reviewed changes
Copy link
Contributor

@epernod epernod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry previous comment was not clear. Here is my suggestion

modules/SofaMiscForceField/SofaMiscForceField_test/MeshMatrixMass_test.cpp Outdated Show resolved Hide resolved
modules/SofaMiscForceField/SofaMiscForceField_test/MeshMatrixMass_test.cpp Outdated Show resolved Hide resolved
damienmarchal and others added 2 commits July 12, 2021 12:17
@damienmarchal @epernod
Update modules/SofaMiscForceField/SofaMiscForceField_test/MeshMatrixM…
8cc3ff9 
…ass_test.cpp

Co-authored-by: erik pernod <erik.pernod@gmail.com>
@damienmarchal @epernod
Update modules/SofaMiscForceField/SofaMiscForceField_test/MeshMatrixM…
9c19856 
…ass_test.cpp

Co-authored-by: erik pernod <erik.pernod@gmail.com>
@epernod epernod added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jul 13, 2021
@fredroy fredroy merged commit 4afe173 into sofa-framework:master Jul 13, 2021
@guparan guparan added this to the v21.12 milestone Oct 1, 2021
@guparan guparan changed the title [FIX] minor compilation warnings [All] Fix minor compilation warnings Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guparan guparan guparan approved these changes

@epernod epernod epernod approved these changes

Assignees
No one assigned
Labels
pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v21.12
Development

Successfully merging this pull request may close these issues.
4 participants
@damienmarchal @fredroy @guparan @epernod