Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SofaSimulationCore] Clearer message when a linear solver is missing #2221

Merged
merged 4 commits into from
Jul 9, 2021

Conversation

alxbilger
Copy link
Contributor

[ERROR]   [DAGNode(Snake)] A linear solver is required, but has not been found. Add a linear solver to your scene to fix this issue. The list of available linear solver components is: [BTDLinearSolver, BlockJacobiPreconditioner, CGLinearSolver, CholeskySolver, JacobiPreconditioner, LULinearSolver, MinResLinearSolver, PrecomputedLinearSolver, PrecomputedWarpPreconditioner, SSORPreconditioner, SVDLinearSolver, ShewchukPCGLinearSolver, SparseCholeskySolver, SparseLDLSolver, SparseLUSolver, WarpPreconditioner].

instead of

[ERROR]   [DAGNode(Snake)] Requires a LinearSolver.

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request labels Jul 1, 2021
Copy link
Contributor

@guparan guparan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this great UX improvement!

@alxbilger
Copy link
Contributor Author

[ci-build][with-all-tests]

@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jul 8, 2021
@damienmarchal damienmarchal merged commit 3117a42 into sofa-framework:master Jul 9, 2021
@damienmarchal
Copy link
Contributor

Ready ? Then merge.

@guparan guparan added this to the v21.12 milestone Oct 1, 2021
@alxbilger alxbilger deleted the missinglinearsolver branch June 28, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement About a possible enhancement pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants