Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[All] Remove deprecated calls and warnings #2210

Merged
merged 9 commits into from
Jun 29, 2021

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Jun 28, 2021

Cleaning PR for the v21.06 release.

  1. remove warnings about unused variables/parameters
  2. transformRotation of Mat enforces if the given Mat is 3x3 or 4x4 (does not make sense otherwise, or could even crash)
  3. add a function toHomogeneousMatrix() for Mat4x4 for RigidTypes (which will use the toHomogenous of Quat)
  4. remove uses of operator= with MultiMatrix in ODESolvers
  5. HeadlessRecorder was using a deprecated feature of VisualParameters (sceneTransform)
  6. Use PathResolver in MultiMapping
  7. Rename Deprecation Macro in BaseData.h, correct the fix message and remove use of setOwnerClass.

Note for 7.: the GUI was displaying either "Base" for owner (when hovering on the Data name) or "no owner found". I dont really know what was supposed to be displayed.
Now with the correction, all the Data will display their owner's name, which seems a bit useless to me.

Before:
prclean_2106_beforename prclean_2106_beforeflags

After:
prclean_2106_aftername prclean_2106_afterflags


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Jun 28, 2021
@fredroy fredroy added this to the v21.06 milestone Jun 28, 2021
@fredroy fredroy added the pr: do not squash To merge instead of squash a pull-request label Jun 28, 2021
@guparan
Copy link
Contributor

guparan commented Jun 28, 2021

Forgive me @fredroy, I savagely used your branch to add a clean commit in Sofa.Config 👼

@fredroy
Copy link
Contributor Author

fredroy commented Jun 29, 2021

[ci-build][with-all-tests]

@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jun 29, 2021
@guparan guparan merged commit 21b5f37 into sofa-framework:master Jun 29, 2021
@fredroy fredroy deleted the remove_deprecated_calls branch October 14, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: clean Cleaning the code pr: do not squash To merge instead of squash a pull-request pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants