Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[All] Disable Drawtool functions using Vec4f #2197

Merged
merged 3 commits into from
Jun 24, 2021

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Jun 24, 2021

#1626 generalized the use of RGBAColor instead of Vec4f to select a color.
And all the functions were deprecated (but still usable) until the v21.06.

For the upcoming release of v21.06, those functions have been deleted, but their definitions are still there, to inform the user how to fix the compilation error.


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: status wip Development in the pull-request is still in progress pr: clean Cleaning the code labels Jun 24, 2021
@fredroy fredroy added this to the v21.06 milestone Jun 24, 2021
@fredroy
Copy link
Contributor Author

fredroy commented Jun 24, 2021

[ci-build]

@guparan guparan added the pr: fast merge Minor change that can be merged without waiting for the 7 review days label Jun 24, 2021
@fredroy
Copy link
Contributor Author

fredroy commented Jun 24, 2021

[ci-build]

@fredroy fredroy added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Jun 24, 2021
@fredroy
Copy link
Contributor Author

fredroy commented Jun 24, 2021

[ci-build]

@epernod epernod added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jun 24, 2021
@epernod epernod merged commit 16e4250 into sofa-framework:master Jun 24, 2021
@fredroy fredroy deleted the remove_vec4f_color branch October 14, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants