-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SofaMiscForceField] Fix MeshMatrixMass duplicate Data parameters #2192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epernod
added
pr: fix
Fix a bug
pr: status to review
To notify reviewers to review this pull-request
labels
Jun 18, 2021
epernod
added
pr: status wip
Development in the pull-request is still in progress
and removed
pr: status to review
To notify reviewers to review this pull-request
labels
Jun 18, 2021
epernod
added
pr: status to review
To notify reviewers to review this pull-request
and removed
pr: status wip
Development in the pull-request is still in progress
labels
Jun 21, 2021
epernod
changed the title
[SofaMiscFF] Fix MeshMatrixMass init and topologicalChanges
[SofaMiscFF] Fix MeshMatrixMass duplicate Data parameters
Jun 21, 2021
[ci-build][with-all-tests] |
alxbilger
approved these changes
Jun 23, 2021
guparan
changed the title
[SofaMiscFF] Fix MeshMatrixMass duplicate Data parameters
[SofaMiscForceField] Fix MeshMatrixMass duplicate Data parameters
Jun 30, 2021
fredroy
requested changes
Jun 30, 2021
fredroy
added
pr: status wip
Development in the pull-request is still in progress
and removed
pr: status to review
To notify reviewers to review this pull-request
labels
Jun 30, 2021
[ci-build][with-all-tests] |
fredroy
added
pr: status ready
Approved a pull-request, ready to be squashed
and removed
pr: status wip
Development in the pull-request is still in progress
labels
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr: breaking
Change possibly inducing a compilation error
pr: fix
Fix a bug
pr: status ready
Approved a pull-request, ready to be squashed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was normal vector Data:
and topological Data with mechanism to update each other then they are changed or topological changes occurs.
No need to have 2 sets of Data, topological Data can be used directly as PointData and EdgeData inherite from Data and support topological changes.
-> Remove the normal Data but keep the names vertexMass and edgeMass which are used in code and scenes.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if