-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[All] issofa_bugfix: cleans and fixes #218
Conversation
…ntainer according to std spec. git-svn-id: https://code.insimo.fr/svn/IS/ISSofa/branches/ISSofa@10404 f8a8aa39-ebdb-4476-bae3-08f188f1b544
git-svn-id: https://code.insimo.fr/svn/IS/ISSofa/branches/ISSofa@10439 f8a8aa39-ebdb-4476-bae3-08f188f1b544
git-svn-id: https://code.insimo.fr/svn/IS/ISSofa/branches/ISSofa@10467 f8a8aa39-ebdb-4476-bae3-08f188f1b544
ADD : Optimizations & cleaning.
git-svn-id: https://code.insimo.fr/svn/IS/ISSofa/branches/ISSofa@10494 f8a8aa39-ebdb-4476-bae3-08f188f1b544
…logyChange() git-svn-id: https://code.insimo.fr/svn/IS/ISSofa/branches/ISSofa@10500 f8a8aa39-ebdb-4476-bae3-08f188f1b544
git-svn-id: https://code.insimo.fr/svn/IS/ISSofa/branches/ISSofa@10512 f8a8aa39-ebdb-4476-bae3-08f188f1b544
git-svn-id: https://code.insimo.fr/svn/IS/ISSofa/branches/ISSofa@10515 f8a8aa39-ebdb-4476-bae3-08f188f1b544
This reverts commit 7507f05d07b5932974a68b121d64101f0f92a678. Conflicts: framework/sofa/core/ObjectFactory.cpp NB FJ: worth investigating later, but right now it just generates tons of warnings and does not seem to comply to the promises the initial commit made
…be reserved for messages that will make the application fail.
…as it is not needed unless an very specific solver is added and it currently crashes in other cases git-svn-id: https://code.insimo.fr/svn/IS/ISSofa/branches/ISSofa@10544 f8a8aa39-ebdb-4476-bae3-08f188f1b544
git-svn-id: https://code.insimo.fr/svn/IS/ISSofa/branches/ISSofa@10545 f8a8aa39-ebdb-4476-bae3-08f188f1b544
…ialized value warning
…andle multiple points generation according to only one source primitive
…plied when a force field is in a child node
…to a non existing point
…ying mechanical objects". Not the best way to handle this, probably bugged, and in all cases it broke projectJacobianMatrix in FixedConstraint, at least with the implementation of constraint Jacobians using sofa::defaulttype::MapMapSparseMatrix. In this implementation row.size() is not equal to the size of the mechanicalObject, but to the number of dofs that are affected by a given constraint equation. This partially reverts commit c4aa645fd431369db795e317cd05df6f86460515
…KToMatrix to get rid of console warnings.
… = P+dN in TaitSurfacePressureForceField (Ref T1019, T1010)
@fjourdes and @ChristianDuriez I think this comes from the collaboration between you guys. |
@@ -223,17 +223,6 @@ class SOFA_SIMULATION_CORE_API MechanicalAddMBK_ToMatrixVisitor : public Mechani | |||
return RESULT_CONTINUE; | |||
} | |||
|
|||
//Masses are now added in the addMBKToMatrix call for all ForceFields | |||
|
|||
virtual Result fwdProjectiveConstraintSet(simulation::Node* /*node*/, core::behavior::BaseProjectiveConstraintSet* c) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this has been removed ?
Is it replaced by MechanicalApplyProjectiveConstraint_ToMatrixVisitor ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's related to
MechanicalMatrixVisitor and MechanicalOperations: fix if using a Linear Solver, projective constraints were wrongly applied when a force field is in a child node
When you have a MechanicalObject and a projective constraint in a (parent) node and a ForceField in a child node, which you have to do if for instance you want to apply it to the DOFs but with a different topology for the elements (a subset, or converting hexas to tetras for example), then the matrix was projected before the forcefield would add its contributions.
In order to fix it in all cases (allowing for both forcefield and projective constraints in child nodes) the solution is now to do it with two visitors.
void solve (Matrix& M, Vector& x, Vector& b) override ; | ||
void invert(Matrix& M) override; | ||
bool addJMInvJtLocal(TMatrix * M, ResMatrixType * result,const JMatrixType * J, double fact) override; | ||
virtual void solve (Matrix& M, Vector& x, Vector& b) override; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
virtual not needed.
@@ -178,7 +178,7 @@ void CatmullRomSplineMapping<TIn, TOut>::apply( const sofa::core::MechanicalPara | |||
|
|||
|
|||
template <class TIn, class TOut> | |||
void CatmullRomSplineMapping<TIn, TOut>::applyJ( const sofa::core::MechanicalParams* mparams, OutDataVecDeriv& outData, const InDataVecDeriv& inData) | |||
void CatmullRomSplineMapping<TIn, TOut>::applyJ( const sofa::core::MechanicalParams* mparams /* PARAMS FIRST */, OutDataVecDeriv& outData, const InDataVecDeriv& inData) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PARAMS_FIRST is to removed.
For me, it's ok. |
Due to missing override
Looks fine to me now |
CentOS: 15 scenes time out Let's : [ci-build][with-all-tests][force-full-build] |
[all] issofa_bugfix: cleans and fixes
This PR will be further discussed during STC#3.
issofa_bugfix
Cleans
Bugfixes
AdvancedTimer::stepNext()
std::unique
result was not usedThis PR:
Reviewers will merge only if all these checks are true.