Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaBaseMechanics] Fix bug when deleting point. Mass vector was not well recomputed. #2164

Merged
merged 1 commit into from
Jun 8, 2021
Merged

[SofaBaseMechanics] Fix bug when deleting point. Mass vector was not well recomputed. #2164

merged 1 commit into from
Jun 8, 2021

Conversation

epernod
Copy link
Contributor

@epernod epernod commented Jun 6, 2021 •
edited
Loading

When removing point, mass vector was not following the vertex buffer. Which is using swap + pop_back.
This bug could create negative mass during further element deletion.

The bug is easy to see with a high mass density:
ezgif com-gif-maker(5)

After fix:
ezgif com-gif-maker(4)

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@epernod
[sofaBaseMechanics] Fix bug when deleting point. Mass vector was not …
7d9fd20 
…following perfectly the vecter buffer which could create negative mass during element deletion.
@epernod epernod added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Jun 6, 2021
@epernod epernod self-assigned this Jun 6, 2021
@epernod
Copy link
Contributor Author

epernod commented Jun 7, 2021

[ci-build][with-all-tests]

@epernod epernod added the pr: fast merge Minor change that can be merged without waiting for the 7 review days label Jun 7, 2021
@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jun 8, 2021
@fredroy fredroy merged commit 26b0753 into sofa-framework:master Jun 8, 2021
hugtalbot pushed a commit to hugtalbot/sofa that referenced this pull request Jun 14, 2021
@epernod @hugtalbot
[sofaBaseMechanics] Fix bug when deleting point. Mass vector was not …
f23b124 
…following perfectly the vecter buffer which could create negative mass during element deletion. (sofa-framework#2164)
@guparan guparan added this to the v21.06 milestone Jun 28, 2021
@guparan guparan changed the title [sofaBaseMechanics] Fix bug when deleting point. Mass vector was not well recomputed. [SofaBaseMechanics] Fix bug when deleting point. Mass vector was not well recomputed. Jun 28, 2021
@epernod epernod deleted the inf_topo_mass branch July 10, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@epernod epernod

Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v21.06
Development

Successfully merging this pull request may close these issues.
3 participants
@epernod @guparan @fredroy