[All] Remove several TopologyDataHandler and headers inclusion in components #2162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epernod
added
pr: status to review
epernod
added
pr: status wip
epernod
force-pushed
the
inf_topologyChanges_PoC
branch
from
51331d5
to
5ca1b26
Compare
epernod
force-pushed
the
inf_clean_subsetData
branch
from
d9d73de
to
afa90a3
Compare
epernod
force-pushed
the
inf_topologyChanges_PoC
branch
from
7bed2fa
to
61f07e6
Compare
epernod
changed the title
epernod
force-pushed
the
inf_topologyChanges_PoC
branch
3 times, most recently
from
fcc7dd2
to
8f83115
Compare
…only redefining a Data resize operation. This is already done directly inside the TopologyData. The destroyFunction should be only overriden if a complex behavior is needed.
epernod
force-pushed
the
inf_clean_subsetData
branch
from
afa90a3
to
3134ba7
Compare
epernod
added
pr: status to review
|
[ci-build][with-all-tests] |
epernod
added
the
pr: fast merge
alxbilger
approved these changes
Jul 8, 2021
fredroy
approved these changes
Jul 8, 2021
fredroy
added
pr: status ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrate PR #2114 and will be merged inside branch inf_topologyChanges_POC
Remove several header includes not needed. Also remove all TopologyDataHandler in constraints as they were only redefining a Data resize operation. This is already done directly inside the TopologyData.
The destroyFunction should be only overridden if a complex behavior is needed.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if