[SofaBaseTopology] add intersection methods #2131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngleIntersections
…ions between a segment and a triangle
epernod
added
pr: new feature
fredroy
requested changes
Jun 7, 2021
| @@ -157,6 +157,11 @@ class EdgeSetGeometryAlgorithms : public PointSetGeometryAlgorithms<DataTypes> | |||
| /** return a pointer to the container of cubature points */ | |||
| NumericalIntegrationDescriptor<Real,1> &getEdgeNumericalIntegrationDescriptor(); | |||
|
|
|||
| bool computeEdgeSegmentIntersection(EdgeID edgeID, | |||
There was a problem hiding this comment.
Not the point of the PR as it is also done in the existing code but it would be better to use Real instead of double.
SofaKernel/modules/SofaBaseTopology/src/SofaBaseTopology/EdgeSetGeometryAlgorithms.inl
Outdated
Show resolved
Hide resolved
SofaKernel/modules/SofaBaseTopology/src/SofaBaseTopology/EdgeSetGeometryAlgorithms.inl
Outdated
Show resolved
Hide resolved
|
|
||
| const Edge& e = this->m_topology->getEdge(edgeID); | ||
| const VecCoord& p = (this->object->read(core::ConstVecCoordId::position())->getValue()); | ||
| const typename DataTypes::Coord& c0 = p[e[0]]; |
There was a problem hiding this comment.
not a requirement but using 'auto' is more readable
SofaKernel/modules/SofaBaseTopology/src/SofaBaseTopology/EdgeSetGeometryAlgorithms.inl
Outdated
Show resolved
Hide resolved
SofaKernel/modules/SofaBaseTopology/src/SofaBaseTopology/TriangleSetGeometryAlgorithms.inl
Outdated
Show resolved
Hide resolved
guparan
added
pr: status wip
fredroy
approved these changes
Jun 9, 2021
fredroy
added
pr: status to review
|
[ci-build][with-all-tests] |
fredroy
added
pr: status ready
hugtalbot
pushed a commit
to hugtalbot/sofa
that referenced
this pull request
Jun 14, 2021
* [sofaBaseTopology] add computeRestTriangleBarycoef method * [TearingEngine] save * [TearingEngine] begin setting up fracture path algo * [TriangleSetGeometryAlgorithms.inl] get intersectionS between a segment and a point * Test commit * [TriangleSetAlgorithms] add output vecCoordKmin in computeSegmentTriangleIntersections * [TriangleSetGeometryAlgorithms] add function to compute all intersections between a segment and a triangle * [SofaGuiQt] remove useless line (sofa-framework#2107) * [Topology] apply request changes (sofa-framework#2131) Co-authored-by: epernod <erik.pernod@gmail.com>
alxbilger
reviewed
Jun 16, 2021
|
|
||
| Real deno, num; | ||
| deno = d1010 * dbaba - dba10 * dba10; | ||
| if (!abs(deno) <= EPS) |
There was a problem hiding this comment.
I suspect a logic issue here
There was a problem hiding this comment.
EdgeSetGeometryAlgorithms.inl:935:9: warning: logical not is only applied to the left hand side of this comparison [-Wlogical-not-parentheses]
if (!abs(deno) <= EPS)
guparan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get intersections between triangle and segment, get intersection between edge and segment.
EDIT from @guparan : this PR also fixes #2107 (STC#11 coding sprint)
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if