Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaMiscCollision] Move back to modules (instead of applications/plugins) #2127

Merged
merged 3 commits into from
Jun 8, 2021
Merged

[SofaMiscCollision] Move back to modules (instead of applications/plugins) #2127

merged 3 commits into from
Jun 8, 2021

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented May 27, 2021

As convened.

To have more consistency with the other SofaMisc* modules.
It should also simplify things when using SofaComponentAll, as SofaMiscCollision was excluded.

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels May 27, 2021
@guparan
Copy link
Contributor

guparan commented May 27, 2021

SofaMiscCollision will still be excluded from SofaComponentAll.
You must add it to the list SOFACOMPONENTALL_MODULES in SofaComponentAll/CMakeLists.txt

@fredroy fredroy added pr: status wip Development in the pull-request is still in progress pr: status to review To notify reviewers to review this pull-request and removed pr: status to review To notify reviewers to review this pull-request pr: status wip Development in the pull-request is still in progress labels May 27, 2021
@fredroy
Copy link
Contributor Author

fredroy commented May 27, 2021

[ci-build][with-all-tests]

@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jun 7, 2021
@epernod epernod merged commit 5aa0bf6 into sofa-framework:master Jun 8, 2021
hugtalbot pushed a commit to hugtalbot/sofa that referenced this pull request Jun 14, 2021
@fredroy @hugtalbot
[SofaMiscCollision] Move back to modules (instead of applications/plu…
b55fcf9 
…gins) (sofa-framework#2127)

* move back sofamisccollision into the modules dir (instead of app/plugins)

* add miscollis to componentall

* Update CMakeLists.txt
@guparan guparan added this to the v21.06 milestone Jun 28, 2021
@fredroy fredroy deleted the move_sofamisccollision branch October 14, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guparan guparan guparan approved these changes

Assignees
No one assigned
Labels
pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v21.06
Development

Successfully merging this pull request may close these issues.
3 participants
@fredroy @guparan @epernod