-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SofaKernel] Removing double load() in Loaders #2094
Merged
epernod
merged 4 commits into
sofa-framework:master
from
hugtalbot:minor_clean_in_MeshLoader_20210517
Jun 7, 2021
Merged
[SofaKernel] Removing double load() in Loaders #2094
epernod
merged 4 commits into
sofa-framework:master
from
hugtalbot:minor_clean_in_MeshLoader_20210517
Jun 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugtalbot
added
pr: fix
Fix a bug
pr: status to review
To notify reviewers to review this pull-request
pr: experimental
Demonstrate an experimental feature
labels
May 17, 2021
hugtalbot
changed the title
[SofaKernel] Minor clean in MeshLoader
[SofaKernel] Removing double load() in Loaders
May 18, 2021
[ci-build][with-all-tests] |
Did you test a scene with a loader below (in the scene file order) a MechanicalObject or Topology ? |
In such a case we get |
guparan
added
pr: status wip
Development in the pull-request is still in progress
and removed
pr: status to review
To notify reviewers to review this pull-request
labels
May 26, 2021
hugtalbot
added
pr: status to review
To notify reviewers to review this pull-request
and removed
pr: status wip
Development in the pull-request is still in progress
labels
May 30, 2021
[ci-build][with-all-tests] |
…shLoader_20210517
fredroy
added
pr: status ready
Approved a pull-request, ready to be squashed
and removed
pr: status to review
To notify reviewers to review this pull-request
labels
Jun 7, 2021
[ci-build][with-all-tests][force-full-build] |
hugtalbot
added a commit
to hugtalbot/sofa
that referenced
this pull request
Jun 14, 2021
* [SofaKernel] Minor clean in MeshLoader * Update MeshLoader.cpp * Fix behavior of StringMeshCreator Co-authored-by: Frederick Roy <fred.roy.me@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion fixes #1666
I would like to know if @damienmarchal or @marques-bruno (if watching) sees possible problems while using SofaQtQuick.
But relying only on the callback should be sufficient.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if