Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaKernel] Removing double load() in Loaders #2094

Merged
merged 4 commits into from
Jun 7, 2021
Merged

[SofaKernel] Removing double load() in Loaders #2094

merged 4 commits into from
Jun 7, 2021

Conversation

hugtalbot
Copy link
Contributor

@hugtalbot hugtalbot commented May 17, 2021 •
edited
Loading

Suggestion fixes #1666
I would like to know if @damienmarchal or @marques-bruno (if watching) sees possible problems while using SofaQtQuick.
But relying only on the callback should be sufficient.

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@hugtalbot hugtalbot added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request pr: experimental Demonstrate an experimental feature labels May 17, 2021
@hugtalbot hugtalbot changed the title [SofaKernel] Minor clean in MeshLoader [SofaKernel] Removing double load() in Loaders May 18, 2021
@epernod
Copy link
Contributor

epernod commented May 18, 2021

[ci-build][with-all-tests]

@epernod
Copy link
Contributor

epernod commented May 18, 2021

Did you test a scene with a loader below (in the scene file order) a MechanicalObject or Topology ?

@hugtalbot
Copy link
Contributor Author

hugtalbot commented May 18, 2021 •
edited
Loading

In such a case we get Source object "@YourLoader" NOT FOUND but it is not related to the load() rather than the component is not even created when placed below.
But this would happen anyway, wouldn't it ?

@hugtalbot hugtalbot removed the pr: experimental Demonstrate an experimental feature label May 26, 2021
@guparan guparan added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels May 26, 2021
@hugtalbot hugtalbot added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels May 30, 2021
@hugtalbot
Copy link
Contributor Author

[ci-build][with-all-tests]

@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jun 7, 2021
@fredroy
Copy link
Contributor

fredroy commented Jun 7, 2021

[ci-build][with-all-tests][force-full-build]

@epernod epernod merged commit c397840 into sofa-framework:master Jun 7, 2021
hugtalbot added a commit to hugtalbot/sofa that referenced this pull request Jun 14, 2021
@hugtalbot @fredroy
[SofaKernel] Removing double load() in Loaders (sofa-framework#2094)
fb1e8c5 
* [SofaKernel] Minor clean in MeshLoader

* Update MeshLoader.cpp

* Fix behavior of StringMeshCreator

Co-authored-by: Frederick Roy <fred.roy.me@gmail.com>
@guparan guparan added this to the v21.06 milestone Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v21.06
Development

Successfully merging this pull request may close these issues.

[Loaders] at init : loading of mesh might be done twice with new callback mechanism
4 participants
@hugtalbot @epernod @fredroy @guparan