Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SofaCUDA] Ignore example scenes using SofaCUDA on CI #2042

Merged
merged 3 commits into from
May 19, 2021

Conversation

guparan
Copy link
Contributor

@guparan guparan commented Apr 23, 2021

Following #2016

I thought SofaCUDA scenes were not tested at all on CI but actually they are (some of them at least).
A .scene-test file is used to ignore all the scenes that require SofaCUDA.

Here are the scenes that are successfully tested (check them out here):

  • StandardTetrahedralFEMForceFieldCPU.scn
  • TetrahedralTensorMassForceFieldCPU.scn
  • beam10x10x46-fem-implicit-CPU.scn
  • beam10x10x46-hexafem-implicit-CPU.scn
  • beam10x10x46-hexafem-rk4-CPU.scn
  • beam16x16x76-fem-implicit-CPU.scn
  • beam16x16x76-hexafem-rk4-CPU.scn
  • quadSpringSphere.scn

Does it makes sense to have non-CUDA scenes in SofaCUDA?
Maybe should we ignore all the plugin scenes?


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@guparan guparan added issue: discussion Open topic of discussion pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Apr 23, 2021
@epernod
Copy link
Contributor

epernod commented Apr 30, 2021

Does it makes sense to have non-CUDA scenes in SofaCUDA?

yes this is to show the diff.
But for me it makes sens to remove the whole directory on the CI.

@guparan
Copy link
Contributor Author

guparan commented May 3, 2021

Thanks for the answer @epernod
Others opinion? @hugtalbot @fredroy @alxbilger @damienmarchal

➡️ To keep the non-CUDA scenes tested by CI: click on the 👍 below
➡️ To ignore all the scenes: click on the 👎 below

@guparan guparan added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels May 5, 2021
@guparan
Copy link
Contributor Author

guparan commented May 5, 2021

[ci-build][with-scene-tests]

@fredroy
Copy link
Contributor

fredroy commented May 18, 2021

[ci-build][with-all-tests]

@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status wip Development in the pull-request is still in progress labels May 18, 2021
@fredroy fredroy merged commit 7b34ece into sofa-framework:master May 19, 2021
@guparan guparan added this to the v21.06 milestone Jun 28, 2021
@guparan guparan deleted the ci_ignore_cuda_examples branch October 29, 2021 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: discussion Open topic of discussion pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants