Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CMake] Set CMake install default component #2037

Merged
merged 2 commits into from
Apr 23, 2021
Merged

[CMake] Set CMake install default component #2037

merged 2 commits into from
Apr 23, 2021

Conversation

guparan
Copy link
Contributor

@guparan guparan commented Apr 22, 2021

Very useful variable to have a default COMPONENT value for every install call 👍
Also, clean 2 missing <build-dir>/cmake --> <build-dir>/lib/cmake for consistency.

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@guparan guparan added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: backport todo This PR will be backported into the release preceeding its milestone. labels Apr 22, 2021
@fredroy fredroy added the pr: status ready Approved a pull-request, ready to be squashed label Apr 23, 2021
@epernod epernod merged commit 7bdc165 into sofa-framework:master Apr 23, 2021
@guparan guparan added this to the v21.06 milestone May 7, 2021
guparan added a commit to guparan/sofa that referenced this pull request May 7, 2021
@guparan
[CMake] Set CMake install default component (sofa-framework#2037)
ef56579 
* [CMake] Set CMAKE_INSTALL_DEFAULT_COMPONENT_NAME to "applications"

It will avoid missing files in SOFA installer (.exe or .run)

* [CMake] CLEAN lib/cmake directory in build tree

# Conflicts:
#	CMakeLists.txt
#	SofaKernel/modules/Sofa.Config/CMakeLists.txt
@guparan guparan added pr: backport done This PR has been backported into the release before its milestone. and removed pr: backport todo This PR will be backported into the release preceeding its milestone. labels Jul 9, 2021
@guparan guparan deleted the set_cmake_install_default_component branch October 29, 2021 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: backport done This PR has been backported into the release before its milestone. pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v21.06
Development

Successfully merging this pull request may close these issues.
3 participants
@guparan @fredroy @epernod