Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaSimulationCore] Move CpuTask class into its own file #1993

Merged
merged 5 commits into from
Apr 21, 2021
Merged

[SofaSimulationCore] Move CpuTask class into its own file #1993

merged 5 commits into from
Apr 21, 2021

Conversation

alxbilger
Copy link
Contributor

  • Move CpuTask class into its own file
  • Remove ThreadSpecificTask class, as it was not used

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: breaking Change possibly inducing a compilation error pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days labels Apr 8, 2021
@alxbilger
Copy link
Contributor Author

[ci-build][with-all-tests]

@hugtalbot hugtalbot added the pr: status to review To notify reviewers to review this pull-request label Apr 9, 2021
@hugtalbot
Copy link
Contributor

The move is obvious a very good point 👍
However, I can not really judge for the ThreadSpecificTask .. @fspadoni maybe ?

@alxbilger alxbilger requested a review from fspadoni April 9, 2021 12:21
@hugtalbot
Copy link
Contributor

Do you have an example of use for the ThreadSpecificTask @fspadoni ? thanks !

fspadoni
fspadoni approved these changes Apr 18, 2021
View reviewed changes
Copy link
Contributor

@fspadoni fspadoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine.
The ThreadSpecificTask was only a prototype class but was never used so it's OK to remove it.

@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Apr 21, 2021
@guparan guparan merged commit a5fbe56 into sofa-framework:master Apr 21, 2021
@guparan guparan added this to the v21.06 milestone Jun 28, 2021
@alxbilger alxbilger deleted the cputask_file branch June 28, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fspadoni fspadoni fspadoni approved these changes

Assignees
No one assigned
Labels
pr: breaking Change possibly inducing a compilation error pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v21.06
Development

Successfully merging this pull request may close these issues.
5 participants
@alxbilger @hugtalbot @fspadoni @guparan @fredroy