Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sofa.Type] Remove stdtype subdirectory #1946

Merged
merged 2 commits into from
Mar 25, 2021
Merged

[Sofa.Type] Remove stdtype subdirectory #1946

merged 2 commits into from
Mar 25, 2021

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Mar 24, 2021

It was deemed too bothersome to have a subdirectory for the types similar to the stl (aka "stdtypes").
This fact is already indicated with the lowercase classname (and filename) anyway.

This PR just remove the subdirectory (and updates the corresponding namespaces and paths)

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request NG1: include-graph See https://github.com/sofa-framework/sofa/issues/1527 labels Mar 24, 2021
@fredroy
Copy link
Contributor Author

fredroy commented Mar 25, 2021

[ci-build][with-all-tests]

@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Mar 25, 2021
@hugtalbot hugtalbot merged commit ebf1402 into sofa-framework:master Mar 25, 2021
@guparan guparan added this to the v21.06 milestone Mar 26, 2021
@fredroy fredroy deleted the remove_stdtype branch October 14, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
NG1: include-graph See https://github.com/sofa-framework/sofa/issues/1527 pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v21.06
Development

Successfully merging this pull request may close these issues.
3 participants
@fredroy @guparan @hugtalbot