[examples] Fix or disable scene tests #1919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guparan
added
pr: fix
|
[ci-build][with-scene-tests] |
fredroy
removed
the
pr: status wip
|
[ci-build][with-scene-tests] |
hugtalbot
added
pr: status to review
|
[ci-build][with-scene-tests] |
guparan
force-pushed
the
fix_or_disable_scene_tests
branch
2 times, most recently
from
ae4fcf9
to
0534d8b
Compare
|
Somebody has to merge sofa-framework/SofaPython3#126 before changing the pointer for SofaPython3... |
guparan
added
pr: status to review
hugtalbot
added
pr: status ready
|
Looks like the SP3 tag hasn't been reset to the master branch, or I am missing something? @guparan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP PR.
For now, it disables all python scenes in Flexible and Compliant.
IMPORTANT: do not merge until https://github.com/sofa-framework/SofaPython3/tree/fix_or_disable_scene_tests is merged into SofaPython3 and ExternalProject tag is reset to master here.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if