Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaGuiQt] Use opaque API instead #1918

Merged
merged 1 commit into from
Mar 15, 2021
Merged

[SofaGuiQt] Use opaque API instead #1918

merged 1 commit into from
Mar 15, 2021

Conversation

alxbilger
Copy link
Contributor

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@guparan guparan added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Mar 15, 2021
@damienmarchal
Copy link
Contributor

Looks ok to me, if the CI says it, got to merge.

@fredroy
Copy link
Contributor

fredroy commented Mar 15, 2021

One of the mac on the CI does not have numpy for python3 (thats why the unit tests are failing) but otherwise seems good for me!

@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Mar 15, 2021
@fredroy fredroy merged commit 039bb03 into sofa-framework:master Mar 15, 2021
@guparan guparan added this to the v21.06 milestone Mar 26, 2021
@alxbilger alxbilger deleted the fixSofaGuiQt branch June 28, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v21.06
Development

Successfully merging this pull request may close these issues.
4 participants
@alxbilger @damienmarchal @fredroy @guparan