Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaGuiQt] Fix compilation when SOFA_DUMP_VISITOR is enabled #1914

Merged
merged 2 commits into from
Mar 12, 2021
Merged

[SofaGuiQt] Fix compilation when SOFA_DUMP_VISITOR is enabled #1914

merged 2 commits into from
Mar 12, 2021

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Mar 12, 2021 •
edited by guparan
Loading

Fix #1841

  • a little bit of cleaning

And Fix #1884 (not related but very small fix indeed)

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Mar 12, 2021
@fredroy fredroy mentioned this pull request Mar 12, 2021
Closed
@maddin200
Copy link
Contributor

perfect :-)

@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Mar 12, 2021
@guparan guparan merged commit f68f55d into sofa-framework:master Mar 12, 2021
@guparan guparan added this to the v21.06 milestone Mar 26, 2021
@fredroy fredroy deleted the fix_1841 branch October 14, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v21.06
Development

Successfully merging this pull request may close these issues.

applications: Resource leak Preprocessor endif without if
3 participants
@fredroy @maddin200 @guparan