Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaFramework] Fix config files for Sofa.GL, for out-of-tree #1911

Merged
merged 2 commits into from
Mar 11, 2021
Merged

[SofaFramework] Fix config files for Sofa.GL, for out-of-tree #1911

merged 2 commits into from
Mar 11, 2021

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Mar 10, 2021

Title says all, forgotten lines and mess with the generated variables (dot and underscore) in SofaFrameworkConfig.cmake.in (and Sofa.GLConfig.in)
Fix out-of-tree compilation (tested with Py3) which could not find GLEW::GLEW target

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Mar 10, 2021
guparan
guparan suggested changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@guparan guparan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sofa.GL is a standalone package and thus should not be handled by SofaFramework package.
Related to my fresh PR #1913

SofaKernel/SofaFramework/SofaFrameworkConfig.cmake.in Outdated Show resolved Hide resolved
SofaKernel/SofaFramework/SofaFrameworkConfig.cmake.in Outdated Show resolved Hide resolved
@guparan guparan added the pr: status wip Development in the pull-request is still in progress label Mar 11, 2021
@guparan guparan removed the pr: status wip Development in the pull-request is still in progress label Mar 11, 2021
@guparan guparan merged commit 10fad52 into sofa-framework:master Mar 11, 2021
@guparan guparan added this to the v21.06 milestone Mar 26, 2021
@fredroy fredroy deleted the fix_install_sofagl branch October 14, 2021 09:48
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guparan guparan guparan requested changes

Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v21.06
Development

Successfully merging this pull request may close these issues.
3 participants
@fredroy @guparan @hugtalbot