Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SofaTest] Add Backtrace::autodump to all tests #191

Merged
merged 1 commit into from
Mar 8, 2017

Conversation

damienmarchal
Copy link
Contributor

@damienmarchal damienmarchal commented Mar 2, 2017

As requested by @matthieu-nesme in #149
(but what is the xml ?)


This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings nor unit test failures.
  • does not break existing scenes.
  • does not break API compatibility.
  • has been reviewed and agreed to be transitional.
  • is more than 1 week old.

Reviewers will merge only if all these checks are true.

@damienmarchal damienmarchal added the pr: fast merge Minor change that can be merged without waiting for the 7 review days label Mar 2, 2017
@matthieu-nesme
Copy link
Member

@damienmarchal, I am talking about these xml files:

[ RUN      ] BilateralInteractionConstraint_test/1.attributesTests
bash: line 1:  2202 Segmentation fault      build/bin/SofaConstraint_test --gtest_output=xml:build/tests/SofaConstraint_test/report.xml 2>&1

(copied from https://ci.inria.fr/sofa-ci/job/centos_clang-3.4_options/262/console)

But I think @guparan is working on the subject.

@guparan
Copy link
Contributor

guparan commented Mar 2, 2017

Did not have time to start this yet. 😢
As discussed last wednesday, the idea would be to simply cat the output of crashed tests during the print-summary() phases (for unit tests and scene tests). So only scripts stuff.

@damienmarchal
Copy link
Contributor Author

So let Guillaume finish...
But is the autodump stuff useful or not ?
If Backtrace is not installed by default how a failing test will print anything ?

@guparan guparan merged commit 7f12dd3 into sofa-framework:master Mar 8, 2017
@guparan guparan changed the title [SofaTest] Add Backtrace::autodump to all tests to ease debugging on … [SofaTest] Add Backtrace::autodump to all tests Mar 8, 2017
@guparan guparan added this to the v17.06 milestone Jun 29, 2017
@damienmarchal damienmarchal deleted the test_autodump branch July 5, 2017 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants