Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SofaHelper] Moves operator>> specialisation for int from set.h to set.cpp #1902

Merged

Conversation

damienmarchal
Copy link
Contributor

Because I have so much branch with this change duplicated that it is worth having it in a PR and forget about that.

Of course, a real refactoring of the reading code would be better but until done let's just have this kind of cleaning .


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@damienmarchal damienmarchal added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Mar 9, 2021
@damienmarchal
Copy link
Contributor Author

[ci]-build][with-scene-tests][with-regressions]

@damienmarchal damienmarchal changed the title [SofaHelper] Move operator>> specialisation for int from set.h to set.cpp [SofaHelper] Moves operator>> specialisation for int from set.h to set.cpp Mar 10, 2021
@damienmarchal damienmarchal added the pr: fast merge Minor change that can be merged without waiting for the 7 review days label Mar 10, 2021
@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Mar 11, 2021
@guparan guparan merged commit 3bc8d57 into sofa-framework:master Mar 11, 2021
@guparan guparan added this to the v21.06 milestone Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants