Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SofaHelper] Replace boost::shared_ptr for std::shared_ptr #1901

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

jnbrunet
Copy link
Contributor

@jnbrunet jnbrunet commented Mar 9, 2021

Maybe breaking, if someone, somewhere, somehow stored ComponentInfo::SPtr or FileInfo::SPtr in its components using directly boost::shared_ptr<T>.


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@jnbrunet jnbrunet added pr: breaking Change possibly inducing a compilation error pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Mar 9, 2021
@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Mar 17, 2021
@fredroy fredroy merged commit c3c6132 into sofa-framework:master Mar 17, 2021
@guparan guparan added this to the v21.06 milestone Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: breaking Change possibly inducing a compilation error pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants