Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[examples] Add missing RequiredPlugin #1895

Merged
merged 2 commits into from
Mar 8, 2021
Merged

[examples] Add missing RequiredPlugin #1895

merged 2 commits into from
Mar 8, 2021

Conversation

Mrbunbun
Copy link
Contributor

@Mrbunbun Mrbunbun commented Mar 5, 2021

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@epernod epernod added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Mar 5, 2021
@epernod
Copy link
Contributor

epernod commented Mar 5, 2021

[ci-build][with-all-tests]

@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Mar 8, 2021
@fredroy fredroy merged commit a40e8f8 into sofa-framework:master Mar 8, 2021
@guparan guparan added the pr: backport done This PR has been backported into the release before its milestone. label Mar 26, 2021
@guparan guparan added this to the v21.06 milestone Mar 26, 2021
@guparan guparan added pr: backport todo This PR will be backported into the release preceeding its milestone. and removed pr: backport done This PR has been backported into the release before its milestone. labels Mar 26, 2021
@guparan guparan changed the title Adding missing plugin [examples] Adding missing RequiredPlugin Mar 30, 2021
@guparan guparan changed the title [examples] Adding missing RequiredPlugin [examples] Add missing RequiredPlugin Mar 30, 2021
guparan pushed a commit to guparan/sofa that referenced this pull request Mar 30, 2021
@fredroy @guparan
Merge pull request sofa-framework#1895 from Mrbunbun/AddingMissingPlugin
e2651c8 
Adding missing plugin
@guparan guparan added pr: backport done This PR has been backported into the release before its milestone. and removed pr: backport todo This PR will be backported into the release preceeding its milestone. labels Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: backport done This PR has been backported into the release before its milestone. pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v21.06
Development

Successfully merging this pull request may close these issues.
4 participants
@Mrbunbun @epernod @guparan @fredroy