Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaOpenCL] Remove use of deleted functions #1880

Merged
merged 1 commit into from
Mar 2, 2021
Merged

[SofaOpenCL] Remove use of deleted functions #1880

merged 1 commit into from
Mar 2, 2021

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Mar 2, 2021

This PR follows latest changes from master and using accessor instead of begin/endEdit()

SofaOpenCL is not activated by default (either in Sofa or the CI). so compilation and tests are not relevant here.

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Mar 2, 2021
@damienmarchal damienmarchal added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Mar 2, 2021
@damienmarchal damienmarchal merged commit 4d11915 into sofa-framework:master Mar 2, 2021
damienmarchal pushed a commit to CRIStAL-PADR/sofa that referenced this pull request Mar 4, 2021
@fredroy @damienmarchal
[SofaOpenCL] Remove use of deleted functions sofa-framework#1880
71f3385 
This PR follows latest changes from master and using accessor instead of begin/endEdit()
SofaOpenCL is not activated by default (either in Sofa or the CI). so compilation and tests are not relevant here.
@guparan guparan added this to the v21.06 milestone Mar 26, 2021
@fredroy fredroy deleted the fix_opencl_master branch October 14, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v21.06
Development

Successfully merging this pull request may close these issues.
3 participants
@fredroy @guparan @damienmarchal