-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SofaPython] Regroup dependencies #1875
[SofaPython] Regroup dependencies #1875
Conversation
[ci-build][with-all-tests][force-full-build] |
find_package(PythonLibs 2.7 REQUIRED) | ||
find_package(SofaGui REQUIRED) | ||
find_package(SofaUserInteraction REQUIRED) | ||
find_package(SofaMiscMapping REQUIRED) | ||
find_package(Eigen3 REQUIRED) | ||
|
||
sofa_find_package(SofaTest QUIET) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
find_package or sofa_find_package :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sofa_find_package to get the cmake variable SOFAPYTHON_HAVE_SOFATEST defined in the cmake.in, etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So all the other find_package in every CMakeLists.txt should become sofa_find_package ?
This sounds nice and mandatory...I'm looking how did the inversion of dependencies. EDIT: ok i saw |
I propagated SofaPython dep changes in more plugins. |
This options affects only Compliant and image since sofa-framework/sofa#1875
SofaPython was needed into SofaTest (to enable python test) and SofaExporter for bindings.
1- then CMake had to enable SofaPython then SofaTest then SofaPython/SofaPython_test, which is quite "bothersome",and made the main SOFA Cmakefile cluttered.
Now if SofaTest is enabled, SofaPython will enable the use of Python_test (and not the other way around)
(NB SofaPython contains a redirection for project including
SofaTest/Python_test.h
)2- SofaExporter is a Sofa module and so, it is quite weird to have a dependency to a plugin in a module.
Now SofaPython will enable SofaExporter bindings if SofaExporter has been enabled before (and not the other way around)
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if