[SofaPython] Regroup dependencies #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredroy
added
pr: status to review
|
[ci-build][with-all-tests][force-full-build] |
| find_package(PythonLibs 2.7 REQUIRED) | ||
| find_package(SofaGui REQUIRED) | ||
| find_package(SofaUserInteraction REQUIRED) | ||
| find_package(SofaMiscMapping REQUIRED) | ||
| find_package(Eigen3 REQUIRED) | ||
|
|
||
| sofa_find_package(SofaTest QUIET) |
There was a problem hiding this comment.
find_package or sofa_find_package :)
There was a problem hiding this comment.
sofa_find_package to get the cmake variable SOFAPYTHON_HAVE_SOFATEST defined in the cmake.in, etc
There was a problem hiding this comment.
So all the other find_package in every CMakeLists.txt should become sofa_find_package ?
|
This sounds nice and mandatory...I'm looking how did the inversion of dependencies. EDIT: ok i saw |
|
I propagated SofaPython dep changes in more plugins. |
guparan
added
pr: status ready
guparan
added a commit
to sofa-framework/ci
that referenced
this pull request
Mar 12, 2021
This options affects only Compliant and image since sofa-framework/sofa#1875
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SofaPython was needed into SofaTest (to enable python test) and SofaExporter for bindings.
1- then CMake had to enable SofaPython then SofaTest then SofaPython/SofaPython_test, which is quite "bothersome",and made the main SOFA Cmakefile cluttered.
Now if SofaTest is enabled, SofaPython will enable the use of Python_test (and not the other way around)
(NB SofaPython contains a redirection for project including
SofaTest/Python_test.h)2- SofaExporter is a Sofa module and so, it is quite weird to have a dependency to a plugin in a module.
Now SofaPython will enable SofaExporter bindings if SofaExporter has been enabled before (and not the other way around)
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if