Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VolumetricRendering] Fix compilation due to removal of params #1869

Merged
merged 1 commit into from
Feb 27, 2021
Merged

[VolumetricRendering] Fix compilation due to removal of params #1869

merged 1 commit into from
Feb 27, 2021

Conversation

hugtalbot
Copy link
Contributor

Everything in the title : data.setValue(XXX) does not take params as parameter anymore

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@hugtalbot hugtalbot added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Feb 26, 2021
@damienmarchal damienmarchal added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Feb 26, 2021
@damienmarchal damienmarchal merged commit 47eaef7 into sofa-framework:master Feb 27, 2021
damienmarchal pushed a commit to CRIStAL-PADR/sofa that referenced this pull request Mar 1, 2021
@hugtalbot @damienmarchal
[VolumetricRendering] Fix compilation due to removal of params (sofa-…
4738492 
…framework#1869)
damienmarchal pushed a commit to CRIStAL-PADR/sofa that referenced this pull request Mar 4, 2021
@hugtalbot @damienmarchal
[VolumetricRendering] Fix compilation due to removal of params (sofa-…
0144ce9 
…framework#1869)
@guparan guparan added this to the v21.06 milestone Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fredroy fredroy

Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v21.06
Development

Successfully merging this pull request may close these issues.
4 participants
@hugtalbot @guparan @fredroy @damienmarchal