Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaMeshCollision] Fix: windows debug linkage of class EmptyFilter #1839

Merged
merged 1 commit into from
Feb 22, 2021
Merged

[SofaMeshCollision] Fix: windows debug linkage of class EmptyFilter #1839

merged 1 commit into from
Feb 22, 2021

Conversation

epernod
Copy link
Contributor

@epernod epernod commented Feb 20, 2021

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@epernod epernod added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Feb 20, 2021
@epernod epernod self-assigned this Feb 20, 2021
@epernod epernod changed the title [SofaMeshCollision] Fix: windows debug linkage of EmptyFilter [SofaMeshCollision] Fix: windows debug linkage of class EmptyFilter Feb 20, 2021
@fredroy
Copy link
Contributor

fredroy commented Feb 22, 2021

Just got the issue myself in Release mode, and this fixed the problem.

@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Feb 22, 2021
@fredroy fredroy merged commit 8e1c350 into sofa-framework:master Feb 22, 2021
@guparan guparan added this to the v21.06 milestone Feb 26, 2021
damienmarchal pushed a commit to CRIStAL-PADR/sofa that referenced this pull request Mar 1, 2021
@epernod @damienmarchal
[SofaMeshCollision] Fix: windows debug linkage of EmptyFilter (sofa-f…
ff67cf5 
…ramework#1839)

(cherry picked from commit 9b5b146)
damienmarchal pushed a commit to CRIStAL-PADR/sofa that referenced this pull request Mar 4, 2021
@epernod @damienmarchal
[SofaMeshCollision] Fix: windows debug linkage of EmptyFilter (sofa-f…
4943b5b 
…ramework#1839)

(cherry picked from commit 9b5b146)
@epernod epernod deleted the inf_fix_debug branch April 12, 2021 22:29
@epernod epernod restored the inf_fix_debug branch April 12, 2021 22:29
@epernod epernod deleted the inf_fix_debug branch July 10, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredroy fredroy fredroy approved these changes

Assignees

@epernod epernod

Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v21.06
Development

Successfully merging this pull request may close these issues.
3 participants
@epernod @fredroy @guparan