-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SofaFramework] Create Sofa.Testing module #1834
[SofaFramework] Create Sofa.Testing module #1834
Conversation
CMakeLists.txt
Outdated
# add tests of previous projects, now that we have Sofa.Testing enabled | ||
set(SOFAKERNEL_LIST_TARGET_UNITTESTS SofaHelper SofaDefaultType SofaCore SofaSimulationCore SofaSimulationGraph) | ||
foreach(target ${SOFAKERNEL_LIST_TARGET_UNITTESTS}) | ||
add_subdirectory(${SOFA_KERNEL_SOURCE_DIR}/modules/${target}/${target}_test) | ||
endforeach() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SofaSimulationGraph_test is missing in tests/CMakeLists.txt though
[ci-build][force-full-build][with-all-tests] |
|
||
## Tests | ||
# cmake_dependent_option(SOFA_TYPE_BUILD_TESTS "Compile the automatic tests" ON "SOFA_BUILD_TESTS OR NOT DEFINED SOFA_BUILD_TESTS" OFF) | ||
# if(SOFA_TYPE_BUILD_TESTS) | ||
# enable_testing() | ||
# add_subdirectory(${PROJECT_NAME}_test) | ||
# endif() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove the whole Sofa.Type_test directory then 👍
GIT_REPOSITORY https://github.com/fredroy/SofaPython3 | ||
GIT_TAG origin/follow_sofa_pr1834 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no PR on https://github.com/sofa-framework/SofaPython3 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was planning to create PR once everything compiles (and everything is OK) but why not yes
GIT_REPOSITORY https://github.com/fredroy/regression | ||
GIT_TAG origin/follow_sofa_pr1834 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can push your changes directly on https://github.com/sofa-framework/Regression and update GIT_TAG only 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok i will push directly the branch in the sofa-framework repo from now on then
Co-authored-by: Guillaume Paran <guillaume.paran@sofa-framework.org>
[ci-build] |
[ci-build][force-full-build][with-all-tests] |
Related to #1827 |
[DEMO]First step for an unified testing system.
This module gathers:
This module needs to be compiled AFTER SofaSimulation, as SofaGTestMain needs SofaSimulationGraph.
Unfortunately, there is still the mess with the plugin SofaTest, which needs to be solved as well.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if