Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaGuiQt] Add new about window UI and url redirect #1801

Merged
merged 5 commits into from
Feb 23, 2021
Merged

[SofaGuiQt] Add new about window UI and url redirect #1801

merged 5 commits into from
Feb 23, 2021

Conversation

hugtalbot
Copy link
Contributor

Now we have an "About" section in the GUI:

Do you like what you see?

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@hugtalbot hugtalbot added enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request labels Feb 9, 2021
epernod
epernod reviewed Feb 10, 2021
View reviewed changes
modules/SofaGuiQt/src/sofa/gui/qt/AboutSOFADialog.h Outdated
#include <sofa/gui/qt/config.h>
#include <QTreeWidgetItem>

#include <set>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some include could be remove I think

epernod
epernod requested changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@epernod epernod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some include could be remove I think

@hugtalbot hugtalbot added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Feb 17, 2021
@hugtalbot
Copy link
Contributor Author

Reviews taken into account sir @epernod

@hugtalbot hugtalbot added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Feb 22, 2021
@epernod epernod added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Feb 23, 2021
@epernod epernod merged commit 018df3d into sofa-framework:master Feb 23, 2021
@guparan guparan added this to the v21.06 milestone Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epernod epernod epernod approved these changes

Assignees
No one assigned
Labels
enhancement About a possible enhancement pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v21.06
Development

Successfully merging this pull request may close these issues.
3 participants
@hugtalbot @epernod @guparan