Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaHelper] Fix AdvandedTimer test with end() #1781

Merged
merged 1 commit into from
Feb 4, 2021
Merged

[SofaHelper] Fix AdvandedTimer test with end() #1781

merged 1 commit into from
Feb 4, 2021

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Feb 4, 2021

I don't know why this was not detected while doing the previous #1770 🤨
Or maybe it was not noticed... 😮

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status wip Development in the pull-request is still in progress labels Feb 4, 2021
@epernod
Copy link
Contributor

epernod commented Feb 4, 2021

wip?

@fredroy
Copy link
Contributor Author

fredroy commented Feb 4, 2021

waiting to compile/test, to be sure 👮‍♂️

@fredroy fredroy added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Feb 4, 2021
epernod
epernod approved these changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@epernod epernod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix test 👍

@epernod epernod added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Feb 4, 2021
@epernod epernod merged commit 3dd90a2 into sofa-framework:master Feb 4, 2021
@guparan guparan added this to the v21.06 milestone Feb 26, 2021
@fredroy fredroy deleted the fix_advancedtimer_end branch October 14, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epernod epernod epernod approved these changes

Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v21.06
Development

Successfully merging this pull request may close these issues.
3 participants
@fredroy @epernod @guparan