Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[all] Depreciate one of the missing use of Aspect in Link and update the code base #1712

Merged
merged 6 commits into from
Jan 21, 2021
Merged

[all] Depreciate one of the missing use of Aspect in Link and update the code base #1712

merged 6 commits into from
Jan 21, 2021

Conversation

damienmarchal
Copy link
Contributor

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@damienmarchal damienmarchal added pr: clean Cleaning the code pr: status to review To notify reviewers to review this pull-request labels Jan 15, 2021
@hugtalbot hugtalbot changed the title [all] Depreciate one of the missing use of Aspect in Data and update the code base. [all] Depreciate one of the missing use of Aspect in Linik and update the code base Jan 20, 2021
@hugtalbot hugtalbot changed the title [all] Depreciate one of the missing use of Aspect in Linik and update the code base [all] Depreciate one of the missing use of Aspect in Link and update the code base Jan 20, 2021
@epernod
Copy link
Contributor

epernod commented Jan 21, 2021

[ci-build][with-all-tests]

@damienmarchal damienmarchal added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jan 21, 2021
@damienmarchal
Copy link
Contributor Author

:)

@damienmarchal damienmarchal added pr: status to review To notify reviewers to review this pull-request and removed pr: status ready Approved a pull-request, ready to be squashed labels Jan 21, 2021
@epernod epernod added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jan 21, 2021
@epernod epernod merged commit 9c6aa70 into sofa-framework:master Jan 21, 2021
@guparan guparan added this to the v21.06 milestone Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v21.06
Development

Successfully merging this pull request may close these issues.
3 participants
@damienmarchal @epernod @guparan