Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SofaGeneralAnimationLoop] MechanicalMatrixMapper: adds template #1703

Merged
merged 2 commits into from
Jan 12, 2021

Conversation

EulalieCoevoet
Copy link
Contributor

The PR just adds the template "Vec1,Vec3" to the component MechanicalMatrixMapper.


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@EulalieCoevoet EulalieCoevoet added enhancement About a possible enhancement pr: fast merge Minor change that can be merged without waiting for the 7 review days labels Jan 11, 2021
@damienmarchal damienmarchal added the pr: status ready Approved a pull-request, ready to be squashed label Jan 12, 2021
@damienmarchal
Copy link
Contributor

Hi Eulalie,

The template instantiation part (in the .cpp) is not synchronized with the extern template part (in MechanicalMatrixMapper.h).
But we can update that in a separate PR

@epernod
Copy link
Contributor

epernod commented Jan 12, 2021

I would add the extern template in the header in this PR. Otherwise we will forgot to add it ;)

@damienmarchal
Copy link
Contributor

Actually we already forgot others :)

@EulalieCoevoet
Copy link
Contributor Author

No problem :)

@epernod epernod merged commit 113cfc6 into sofa-framework:master Jan 12, 2021
@guparan guparan added this to the v21.06 milestone Jan 18, 2021
@EulalieCoevoet EulalieCoevoet deleted the addTemplateToMMMapper branch January 25, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement About a possible enhancement pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants