[CMake] Macro replace dot with underscore for preprocessor defines #1701
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modules for pluginization contain a dot (Sofa.GL, Sofa.Types, etc),
and custom macro (sofa_create_package_with_targets) generates preprocessor definitions according to the name.
So with the new modules name, the macro creates a preprocessor definition with a dot '.' , but this is not permitted by the C preprocessor.
So this PR replaces a '.' with a '_' for the generated definitions.
Fix #1695 (and seems to remove a warning generated by clang)
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if