Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaKernel] Remove last template parameter in Visitor::for_each/for_each_r #1689

Merged
merged 2 commits into from
Jan 7, 2021
Merged

[SofaKernel] Remove last template parameter in Visitor::for_each/for_each_r #1689

merged 2 commits into from
Jan 7, 2021

Conversation

damienmarchal
Copy link
Contributor

This last parameter can be deduced from the container traits so there is no need to specify it.
This allow to simplifying some calling point as in MechanicalVisitor & UpdateMappingVisitor.h

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@damienmarchal damienmarchal added the pr: status wip Development in the pull-request is still in progress label Jan 1, 2021
@epernod
Copy link
Contributor

epernod commented Jan 1, 2021

first PR of the year! 🥇

@damienmarchal damienmarchal added pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Jan 4, 2021
@damienmarchal
Copy link
Contributor Author

And it pass tests at first time :)

@damienmarchal damienmarchal removed the pr: fast merge Minor change that can be merged without waiting for the 7 review days label Jan 4, 2021
@hugtalbot hugtalbot added pr: breaking Change possibly inducing a compilation error pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Jan 6, 2021
@damienmarchal
[SofaKernel] Remove last template parameter in Visitor::for_each/for_…
8e0c090 
…each_r

This parameter can be deduced from the container traits so there is
no need to specify it. This allow to simplifying some calling point as in MechanicalVisitor & UpdateMappingVisitor.h
@damienmarchal
[SofaKernel] add backward intégrée.
5ce87a7
@damienmarchal
Copy link
Contributor Author

I did the change requested.

@damienmarchal damienmarchal added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress pr: breaking Change possibly inducing a compilation error labels Jan 7, 2021
@jnbrunet jnbrunet added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jan 7, 2021
@jnbrunet jnbrunet merged commit 022d568 into sofa-framework:master Jan 7, 2021
@guparan guparan added this to the v21.06 milestone Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v21.06
Development

Successfully merging this pull request may close these issues.
5 participants
@damienmarchal @epernod @guparan @jnbrunet @hugtalbot