Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[runSofa] CLEAN unused dep to SofaGeneralLoader #1648

Merged
merged 1 commit into from
Dec 7, 2020
Merged

[runSofa] CLEAN unused dep to SofaGeneralLoader #1648

merged 1 commit into from
Dec 7, 2020

Conversation

guparan
Copy link
Contributor

@guparan guparan commented Dec 4, 2020

Fixing build error on sofa-custom: https://ci.inria.fr/sofa-ci-dev/job/sofa-custom/683/CI_CONFIG=ubuntu_gcc-7,CI_TYPE=release/console

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@guparan guparan added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Dec 4, 2020
@jnbrunet jnbrunet added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Dec 7, 2020
@jnbrunet jnbrunet merged commit 6ff97aa into master Dec 7, 2020
@jnbrunet jnbrunet deleted the runsofa-clean-dep branch December 7, 2020 16:49
guparan pushed a commit that referenced this pull request Dec 8, 2020
@jnbrunet @guparan
Merge pull request #1648 from sofa-framework/runsofa-clean-dep
28a06d2 
[runSofa] CLEAN unused dep to SofaGeneralLoader
@guparan guparan added this to the v20.12 milestone Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v20.12
Development

Successfully merging this pull request may close these issues.
2 participants
@guparan @jnbrunet