Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaHelper] Remove OpenGL dependency in vector_device #1646

Merged
merged 1 commit into from
Dec 8, 2020
Merged

[SofaHelper] Remove OpenGL dependency in vector_device #1646

merged 1 commit into from
Dec 8, 2020

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Dec 3, 2020

Basically just replace GLuint and some OpenGL lines of code inside of it.

(related to #1645 )

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status wip Development in the pull-request is still in progress pr: clean Cleaning the code labels Dec 3, 2020
@fredroy fredroy mentioned this pull request Dec 3, 2020
Merged
@fredroy
Copy link
Contributor Author

fredroy commented Dec 4, 2020

[ci-build][with-all-tests]

@fredroy fredroy mentioned this pull request Dec 4, 2020
Merged
@fredroy fredroy added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Dec 7, 2020
@jnbrunet
Copy link
Contributor

jnbrunet commented Dec 8, 2020

Looks fine to me, build and tests are passing (windows fails due to lack of free space).

fast-merge -> let's merge this to alleviate our dev meetings

@jnbrunet jnbrunet added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Dec 8, 2020
@jnbrunet jnbrunet merged commit b980aba into sofa-framework:master Dec 8, 2020
guparan pushed a commit that referenced this pull request Dec 8, 2020
@jnbrunet @guparan
Merge pull request #1646 from fredroy/vectordevice_remove_ogl
7459546 
[SofaHelper] Remove OpenGL dependency in vector_device
@fredroy fredroy deleted the vectordevice_remove_ogl branch December 10, 2020 16:02
@guparan guparan added this to the v20.12 milestone Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v20.12
Development

Successfully merging this pull request may close these issues.
3 participants
@fredroy @jnbrunet @guparan