Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaMacros] FIX plugins RPATH #1619

Merged
merged 2 commits into from
Nov 27, 2020
Merged

[SofaMacros] FIX plugins RPATH #1619

merged 2 commits into from
Nov 27, 2020

Conversation

guparan
Copy link
Contributor

@guparan guparan commented Nov 23, 2020

This PR adds custom RPATH to handle dependencies to relocatable targets that will be installed in the "plugins" directory.

3 cases are handled:

  • A non-relocatable library depends on a relocatable library
  • A relocatable library depends on a relocatable library
  • A relocatable library depends on a non-relocatable library

WARNING: note that this is a hacky fix based on the hacky RELOCATABLE "feature".
TODO: rework the CMake files to replace the relocatable mechanism by something more standard.

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@guparan guparan added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Nov 23, 2020
@jnbrunet jnbrunet added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Nov 27, 2020
@jnbrunet
Copy link
Contributor

I approve 👍

@jnbrunet jnbrunet merged commit 384b233 into sofa-framework:master Nov 27, 2020
jnbrunet pushed a commit that referenced this pull request Nov 27, 2020
@guparan @jnbrunet
[SofaMacros] FIX plugins RPATH (#1619)
a0ea5fc 
* [SofaMacros] FIX rpath for modules and plugins

* [tools] FIX Windows postinstall fixup for dll finding
guparan added a commit that referenced this pull request Nov 30, 2020
@guparan
[SofaMacros] FIX RELOCATABLE_INSTALL_DIR target property
3c0f6a9 
Following #1619
@guparan guparan mentioned this pull request Nov 30, 2020
Merged
jnbrunet pushed a commit that referenced this pull request Dec 1, 2020
@guparan
[SofaMacros] FIX RELOCATABLE_INSTALL_DIR target property (#1631)
aa6749b 
Following #1619
jnbrunet pushed a commit that referenced this pull request Dec 1, 2020
@guparan @jnbrunet
[SofaMacros] FIX RELOCATABLE_INSTALL_DIR target property (#1631)
e5d2ad9 
Following #1619
guparan added a commit that referenced this pull request Dec 8, 2020
@guparan
[SofaMacros] FIX plugins RPATH (#1619)
31611aa 
* [SofaMacros] FIX rpath for modules and plugins

* [tools] FIX Windows postinstall fixup for dll finding
guparan added a commit that referenced this pull request Dec 8, 2020
@guparan
[SofaMacros] FIX RELOCATABLE_INSTALL_DIR target property (#1631)
b8aefb0 
Following #1619
@guparan guparan mentioned this pull request Jan 14, 2021
Merged
@guparan guparan added this to the v20.12 milestone Jan 18, 2021
@guparan guparan deleted the fix_plugins_rpath_hacky branch October 29, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v20.12
Development

Successfully merging this pull request may close these issues.
2 participants
@guparan @jnbrunet