[SofaMiscTopology] Add component TopologyChecker #1594

epernod · 2020-11-06T17:49:46Z

This PR add a component called TopologyChecker to be added in the scene and link to a MeshTopology / TopologyContainer in order to check the topology either on demand or every end of step.

The methods used to check the topology is similar to the code inside the method xxxSetTopologyContainer::CheckTopology()
which will be removed.

This PR use changes from PR #1593 and won't compile until the previous one is merged

Fix #1367

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

it builds with SUCCESS for all platforms on the CI.
it does not generate new warnings.
it does not generate new unit test failures.
it does not generate new scene test failures.
it does not break API compatibility.
it is more than 1 week old (or has fast-merge label).

modules/SofaMiscTopology/src/SofaMiscTopology/TopologyChecker.cpp

epernod · 2020-12-11T17:24:48Z

[ci-build][with-all-tests]

fredroy · 2020-12-12T12:30:10Z

Is there any ... test 🤓 ?

epernod · 2020-12-12T12:34:21Z

test the component that will do the tests. Could be possible I think

epernod · 2021-03-06T01:12:41Z

[ci-build][with-all-tests]

epernod · 2021-03-24T00:52:33Z

[ci-build][with-all-tests]

…to be able to test container and cross containes seperatly

…angles

epernod · 2021-03-25T01:29:35Z

[ci-build][with-all-tests]

epernod · 2021-03-25T15:52:37Z

@fredroy you wanted some tests.... I have added "some"... I know 2 are failing but I think the mesh is wrong. I will fix that in another PR

fredroy · 2021-03-25T16:27:43Z

modules/SofaMiscTopology/SofaMiscTopology_test/TopologyChecker_test.cpp

+        EXPECT_MSG_NOEMIT(Error);
+        EXPECT_EQ(checker->checkTriangleToEdgeCrossContainer(), true);
+
+        sofa::helper::WriteAccessor< sofa::core::objectmodel::Data<sofa::helper::vector<Topology::Edge> > > edges = topoCon->d_edge;


Advice: for super long line like that, use auto.
And in this case: auto edges = sofa::helper::getWriteAccessor(topoCon->d_edge);

thanks, done!

fredroy · 2021-03-25T16:30:14Z

modules/SofaMiscTopology/src/SofaMiscTopology/TopologyChecker.cpp

+        const auto& edge = my_edges[i];
+        if (edge[0] == edge[1]) {
+            msg_error() << "CheckEdgeTopology failed: edge " << i << " has 2 identical vertices: " << edge;
+            res = false;


Maybe cut the loop once res = false ? (or add the test i < nbE && !res in the for loop)

yes, I hesitated, the idea was to catch all the errors... but it quickly become a mess..

fredroy · 2021-03-25T16:31:57Z

modules/SofaMiscTopology/src/SofaMiscTopology/TopologyChecker.cpp

+        }
+    }
+
+    if (simulation::AnimateEndEvent::checkEventType(event) && d_eachStep.getValue())


empty statement if animateEnd, so I guess you can remove this

in fact it was not supposed to be empty

modules/SofaMiscTopology/src/SofaMiscTopology/TopologyChecker.h

fredroy · 2021-03-25T16:34:56Z

@fredroy you wanted some tests.... I have added "some"... I know 2 are failing but I think the mesh is wrong. I will fix that in another PR

Could you identify them in the code (in a comment, maybe add the url or the number of this PR)
In case you dont have time to solve them or something like that; otherwise we wont know when these tests had failed 😏

…hecker_test

epernod · 2021-03-25T21:59:05Z

@fredroy you wanted some tests.... I have added "some"... I know 2 are failing but I think the mesh is wrong. I will fix that in another PR

Could you identify them in the code (in a comment, maybe add the url or the number of this PR)
In case you dont have time to solve them or something like that; otherwise we wont know when these tests had failed 😏

In fact the checker had a bug. All the tests are now working. Thanks for the review, the tests were worth it!

epernod added 11 commits November 6, 2020 18:42

[SofaMiscTopology] Add TopologyChecker component

981d3bd

[SofaMiscTopology] Fix Edge container check in topology checker

d016185

[SofaMiscTopology] Add Triangle container check in topology checker

2f47af7

[SofaMiscTopology] Fix TopologyChecker due to modularization

401f3d2

[SofaMiscTopology] Add TopologyChecker activation methods

3718779

[SofaMiscTopology] Update TopologyChecker TopologyElementType usage

380aaf2

[SofaMiscTopology] Fix TopologyChecker CheckTriangleTopology

717dfc9

[SofaMiscTopology] Add TopologyChecker CheckTetrahedronTopology method

1f36447

[SofaMiscTopology] Add TopologyChecker CheckQuadTopology method

6b03703

[SofaMiscTopology] Add TopologyChecker CheckHexahedronTopology method

fecee15

[SofaMiscTopology] Remove logs in CheckTopology engine

689f9db

epernod added enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request pr: new feature Implement a new feature labels Nov 6, 2020

epernod self-assigned this Nov 6, 2020

[SofaMiscTopology] Move TopologyChecker for modularization

156254a

guparan added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Nov 12, 2020

epernod commented Nov 12, 2020

View reviewed changes

modules/SofaMiscTopology/src/SofaMiscTopology/TopologyChecker.cpp Outdated Show resolved Hide resolved

epernod added 2 commits November 25, 2020 09:42

Merge branch 'master' into inf_topologyChecker

e46183d

[SofaMiscTopology] Fix code to integrate recent changes in master

22d5492

epernod added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Dec 11, 2020

epernod added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Dec 15, 2020

epernod added 2 commits March 24, 2021 01:51

Fix several possible bugs while checking the checker

92382ed

Add Triangle and Tetrahedron topologyCheck tests

52d69d5

epernod added 5 commits March 25, 2021 00:38

[TopologyChecker] Split all checkTopology methods in several methods …

ef0ae15

…to be able to test container and cross containes seperatly

[SofaMiscTopology_test] Update topologyChecker test for edges and tri…

a0de1b8

…angles

[SofaBaseTopology] turn Data quad and hexahedron as public

57cc063

Fix forgot to return a value

ea49318

Add test for tetrahedron hexahedron and quad topology

c79692b

epernod added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Mar 25, 2021

Fix compilation

2533354

epernod requested a review from fredroy March 25, 2021 15:52

fredroy reviewed Mar 25, 2021

View reviewed changes

modules/SofaMiscTopology/src/SofaMiscTopology/TopologyChecker.h Outdated Show resolved Hide resolved

epernod added 2 commits March 25, 2021 22:50

Fix some small issues in TopologyCheck and use some auto in topologyC…

99f8d3b

…hecker_test

Fix CheckTopology_test wrong test

258add0

epernod added 2 commits March 31, 2021 10:54

Add topologyChecker class doc

524daeb

Merge branch 'master' into inf_topologyChecker

6c46a25

epernod added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Mar 31, 2021

epernod merged commit f769430 into sofa-framework:master Apr 2, 2021

epernod deleted the inf_topologyChecker branch April 12, 2021 22:30

guparan added this to the v21.06 milestone Jun 28, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SofaMiscTopology] Add component TopologyChecker #1594

[SofaMiscTopology] Add component TopologyChecker #1594

epernod commented Nov 6, 2020 •

edited

Loading

epernod commented Dec 11, 2020

fredroy commented Dec 12, 2020

epernod commented Dec 12, 2020

epernod commented Mar 6, 2021

epernod commented Mar 24, 2021

epernod commented Mar 25, 2021

epernod commented Mar 25, 2021

fredroy Mar 25, 2021

epernod Mar 25, 2021

fredroy Mar 25, 2021

epernod Mar 25, 2021 •

edited

Loading

fredroy Mar 25, 2021

epernod Mar 25, 2021

fredroy commented Mar 25, 2021

epernod commented Mar 25, 2021

[SofaMiscTopology] Add component TopologyChecker #1594

[SofaMiscTopology] Add component TopologyChecker #1594

Conversation

epernod commented Nov 6, 2020 • edited Loading

epernod commented Dec 11, 2020

fredroy commented Dec 12, 2020

epernod commented Dec 12, 2020

epernod commented Mar 6, 2021

epernod commented Mar 24, 2021

epernod commented Mar 25, 2021

epernod commented Mar 25, 2021

fredroy Mar 25, 2021

Choose a reason for hiding this comment

epernod Mar 25, 2021

Choose a reason for hiding this comment

fredroy Mar 25, 2021

Choose a reason for hiding this comment

epernod Mar 25, 2021 • edited Loading

Choose a reason for hiding this comment

fredroy Mar 25, 2021

Choose a reason for hiding this comment

epernod Mar 25, 2021

Choose a reason for hiding this comment

fredroy commented Mar 25, 2021

epernod commented Mar 25, 2021

epernod commented Nov 6, 2020 •

edited

Loading

epernod Mar 25, 2021 •

edited

Loading